style cleanup

This commit is contained in:
2013-10-21 23:35:08 +00:00
parent 4b0ff02aeb
commit 7c8c49a34a
10 changed files with 35 additions and 25 deletions

View File

@@ -902,7 +902,7 @@ static void emdm_pass_attrib_vertex_glsl(DMVertexAttribs *attribs, BMLoop *loop,
for (i = 0; i < attribs->tottface; i++) { for (i = 0; i < attribs->tottface; i++) {
const float *uv; const float *uv;
if(attribs->tface[i].em_offset != -1) { if (attribs->tface[i].em_offset != -1) {
const MLoopUV *luv = BM_ELEM_CD_GET_VOID_P(loop, attribs->tface[i].em_offset); const MLoopUV *luv = BM_ELEM_CD_GET_VOID_P(loop, attribs->tface[i].em_offset);
uv = luv->uv; uv = luv->uv;
} }
@@ -917,7 +917,7 @@ static void emdm_pass_attrib_vertex_glsl(DMVertexAttribs *attribs, BMLoop *loop,
} }
for (i = 0; i < attribs->totmcol; i++) { for (i = 0; i < attribs->totmcol; i++) {
GLubyte col[4]; GLubyte col[4];
if(attribs->mcol[i].em_offset != -1) { if (attribs->mcol[i].em_offset != -1) {
const MLoopCol *cp = BM_ELEM_CD_GET_VOID_P(loop, attribs->mcol[i].em_offset); const MLoopCol *cp = BM_ELEM_CD_GET_VOID_P(loop, attribs->mcol[i].em_offset);
col[0] = cp->b; col[1] = cp->g; col[2] = cp->r; col[3] = cp->a; col[0] = cp->b; col[1] = cp->g; col[2] = cp->r; col[3] = cp->a;
} }

View File

@@ -584,7 +584,7 @@ void BLI_mempool_clear_ex(BLI_mempool *pool, const int totelem_reserve)
/* free all after pool->maxchunks */ /* free all after pool->maxchunks */
for (mpchunk = BLI_findlink(&pool->chunks, (int)maxchunks); mpchunk; mpchunk = mpchunk_next) { for (mpchunk = BLI_findlink(&pool->chunks, (int)maxchunks); mpchunk; mpchunk = mpchunk_next) {
mpchunk_next = mpchunk->next; mpchunk_next = mpchunk->next;
BLI_remlink(&pool->chunks, mpchunk); BLI_remlink(&pool->chunks, mpchunk);
mempool_chunk_free(mpchunk, pool->flag); mempool_chunk_free(mpchunk, pool->flag);

View File

@@ -944,7 +944,7 @@ void BM_face_triangulate(BMesh *bm, BMFace *f,
} }
if ((!use_beauty) || (!r_faces_new)){ if ((!use_beauty) || (!r_faces_new)) {
/* we can't delete the real face, because some of the callers expect it to remain valid. /* we can't delete the real face, because some of the callers expect it to remain valid.
* so swap data and delete the last created tri */ * so swap data and delete the last created tri */
bmesh_face_swap_data(bm, f, f_new); bmesh_face_swap_data(bm, f, f_new);
@@ -979,7 +979,8 @@ void BM_face_triangulate(BMesh *bm, BMFace *f,
if (nf_i < edge_array_len) { if (nf_i < edge_array_len) {
r_faces_new[nf_i++] = f_a; r_faces_new[nf_i++] = f_a;
} else { }
else {
f_new = f_a; f_new = f_a;
break; break;
} }
@@ -990,7 +991,8 @@ void BM_face_triangulate(BMesh *bm, BMFace *f,
if (nf_i < edge_array_len) { if (nf_i < edge_array_len) {
r_faces_new[nf_i++] = f_b; r_faces_new[nf_i++] = f_b;
} else { }
else {
f_new = f_b; f_new = f_b;
break; break;
} }

View File

@@ -37,7 +37,7 @@
#include "intern/bmesh_walkers_private.h" #include "intern/bmesh_walkers_private.h"
/* pop into stack memory (common operation) */ /* pop into stack memory (common operation) */
#define BMW_state_remove_r(walker, owalk) { \ #define BMW_state_remove_r(walker, owalk) { \
memcpy(owalk, BMW_current_state(walker), sizeof(*(owalk))); \ memcpy(owalk, BMW_current_state(walker), sizeof(*(owalk))); \
BMW_state_remove(walker); \ BMW_state_remove(walker); \
} (void)0 } (void)0

View File

@@ -142,11 +142,11 @@ static void bm_loop_pair_from_verts(BMVert *v_a, BMVert *v_b,
static void bm_loop_pair_test_copy(BMLoop *l_pair_a[2], BMLoop *l_pair_b[2]) static void bm_loop_pair_test_copy(BMLoop *l_pair_a[2], BMLoop *l_pair_b[2])
{ {
/* if the first one is set, we know the second is too */ /* if the first one is set, we know the second is too */
if (l_pair_a[0] && l_pair_b[0] == NULL) { if (l_pair_a[0] && l_pair_b[0] == NULL) {
l_pair_b[0] = l_pair_a[1]; l_pair_b[0] = l_pair_a[1];
l_pair_b[1] = l_pair_a[0]; l_pair_b[1] = l_pair_a[0];
} }
else if (l_pair_b[0] && l_pair_a[0] == NULL) { else if (l_pair_b[0] && l_pair_a[0] == NULL) {
l_pair_a[0] = l_pair_b[1]; l_pair_a[0] = l_pair_b[1];
l_pair_a[1] = l_pair_b[0]; l_pair_a[1] = l_pair_b[0];
} }

View File

@@ -116,9 +116,10 @@ void FastGaussianBlurOperation::deinitExecution()
void *FastGaussianBlurOperation::initializeTileData(rcti *rect) void *FastGaussianBlurOperation::initializeTileData(rcti *rect)
{ {
/* lockMutex(); #if 0
if (!this->m_iirgaus) { lockMutex();
MemoryBuffer *newBuf = (MemoryBuffer *)this->m_inputProgram->initializeTileData(rect); if (!this->m_iirgaus) {
MemoryBuffer *newBuf = (MemoryBuffer *)this->m_inputProgram->initializeTileData(rect);
MemoryBuffer *copy = newBuf->duplicate(); MemoryBuffer *copy = newBuf->duplicate();
updateSize(); updateSize();
@@ -144,9 +145,9 @@ void *FastGaussianBlurOperation::initializeTileData(rcti *rect)
} }
unlockMutex(); unlockMutex();
return this->m_iirgaus; return this->m_iirgaus;
}*/ #else
lockMutex(); lockMutex();
if (this->m_iirgaus) { if (this->m_iirgaus) {
// if this->m_iirgaus is set, we don't do tile rendering, so // if this->m_iirgaus is set, we don't do tile rendering, so
// we can return the already calculated cache // we can return the already calculated cache
@@ -159,7 +160,7 @@ void *FastGaussianBlurOperation::initializeTileData(rcti *rect)
if (use_tiles) { if (use_tiles) {
unlockMutex(); unlockMutex();
} }
MemoryBuffer *buffer = (MemoryBuffer *)this->m_inputProgram->initializeTileData(NULL); MemoryBuffer *buffer = (MemoryBuffer *)this->m_inputProgram->initializeTileData(NULL);
rcti *buf_rect = buffer->getRect(); rcti *buf_rect = buffer->getRect();
@@ -181,19 +182,20 @@ void *FastGaussianBlurOperation::initializeTileData(rcti *rect)
} }
else { else {
if (sx > 0.0f) { if (sx > 0.0f) {
for (c = 0; c < COM_NUMBER_OF_CHANNELS; ++c) for (c = 0; c < COM_NUMBER_OF_CHANNELS; ++c)
IIR_gauss(tile, sx, c, 1); IIR_gauss(tile, sx, c, 1);
} }
if (sy > 0.0f) { if (sy > 0.0f) {
for (c = 0; c < COM_NUMBER_OF_CHANNELS; ++c) for (c = 0; c < COM_NUMBER_OF_CHANNELS; ++c)
IIR_gauss(tile, sy, c, 2); IIR_gauss(tile, sy, c, 2);
} }
} }
if (!use_tiles) { if (!use_tiles) {
this->m_iirgaus = tile; this->m_iirgaus = tile;
unlockMutex(); unlockMutex();
} }
return tile; return tile;
#endif
} }
void FastGaussianBlurOperation::deinitializeTileData(rcti *rect, void *data) void FastGaussianBlurOperation::deinitializeTileData(rcti *rect, void *data)

View File

@@ -3158,9 +3158,14 @@ uiBut *uiDefBut(uiBlock *block, int type, int retval, const char *str, int x, in
return but; return but;
} }
/* if _x_ is a power of two (only one bit) return the power, /**
* if \a _x_ is a power of two (only one bit) return the power,
* otherwise return -1. * otherwise return -1.
* (1<<findBitIndex(x))==x for powers of two. *
* for powers of two:
* \code{.c}
* ((1 << findBitIndex(x)) == x);
* \endcode
*/ */
static int findBitIndex(unsigned int x) static int findBitIndex(unsigned int x)
{ {

View File

@@ -2142,7 +2142,8 @@ static int marker_jump_exec(bContext *C, wmOperator *op)
closest = marker->frame; closest = marker->frame;
found = true; found = true;
} }
} else { }
else {
if (marker->frame < CFRA && (!found || closest < marker->frame)) { if (marker->frame < CFRA && (!found || closest < marker->frame)) {
closest = marker->frame; closest = marker->frame;
found = true; found = true;

View File

@@ -3695,7 +3695,7 @@ static const char *cpp_classes = ""
" typename Tcollection_funcs>\n" " typename Tcollection_funcs>\n"
"class Collection : public Tcollection_funcs {\n" "class Collection : public Tcollection_funcs {\n"
"public:\n" "public:\n"
" Collection(const PointerRNA &p) : Tcollection_funcs(p), ptr(p) {}\n" " Collection(const PointerRNA &p) : Tcollection_funcs(p), ptr(p) {}\n"
"\n" "\n"
" void begin(CollectionIterator<T, Tbegin, Tnext, Tend>& iter)\n" " void begin(CollectionIterator<T, Tbegin, Tnext, Tend>& iter)\n"
" { iter.begin(ptr); }\n" " { iter.begin(ptr); }\n"

View File

@@ -89,7 +89,7 @@ static PyObject *make_ffmpeg_info(void)
PyStructSequence_SET_ITEM(ffmpeg_info, pos++, obj) PyStructSequence_SET_ITEM(ffmpeg_info, pos++, obj)
#ifdef WITH_FFMPEG #ifdef WITH_FFMPEG
# define FFMPEG_LIB_VERSION(lib) { \ # define FFMPEG_LIB_VERSION(lib) { \
curversion = lib ## _version(); \ curversion = lib ## _version(); \
SetObjItem(Py_BuildValue("(iii)", \ SetObjItem(Py_BuildValue("(iii)", \
curversion >> 16, (curversion >> 8) % 256, curversion % 256)); \ curversion >> 16, (curversion >> 8) % 256, curversion % 256)); \
@@ -97,7 +97,7 @@ static PyObject *make_ffmpeg_info(void)
curversion >> 16, (curversion >> 8) % 256, curversion % 256)); \ curversion >> 16, (curversion >> 8) % 256, curversion % 256)); \
} (void)0 } (void)0
#else #else
# define FFMPEG_LIB_VERSION(lib) { \ # define FFMPEG_LIB_VERSION(lib) { \
SetStrItem("Unknown"); \ SetStrItem("Unknown"); \
SetStrItem("Unknown"); \ SetStrItem("Unknown"); \
} (void)0 } (void)0