archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Cleanup/sanitize usages of G.debug_value.

Browse Source 
There was no documentation at all, some very bad practices (like using
G.debug_value > 0 as some sort of global debug print switch), and even
an overlapping use of '1' value...

Also, python setter did not check for valid range (since this is a
short, not an int).
This commit is contained in:
Bastien Montagne
2019-01-16 19:41:29 +01:00
parent feaf846f93
commit 8102200006
6 changed files with 34 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/python/intern/bpy_app.c
View File

@@ -297,7 +297,7 @@ static PyObject *bpy_app_binary_path_python_get(PyObject *self, void *UNUSED(clo
}
PyDoc_STRVAR(bpy_app_debug_value_doc,
"Int, number which can be set to non-zero values for testing purposes"
"Short, number which can be set to non-zero values for testing purposes"
);
static PyObject *bpy_app_debug_value_get(PyObject *UNUSED(self), void *UNUSED(closure))
{
@@ -313,7 +313,13 @@ static int bpy_app_debug_value_set(PyObject *UNUSED(self), PyObject *value, void
return -1;
}
G.debug_value = param;
if (param < SHRT_MIN || param > SHRT_MAX) {
PyErr_SetString(PyExc_ValueError,
"bpy.app.debug_value can only be set to short range [-32768, 32767]");
return -1;
}
G.debug_value = (short)param;
WM_main_add_notifier(NC_WINDOW, NULL);