Fix T59495, T59992, T59904, T59178, T60598: broken keyframed value editing.
This removes a bunch of animation/driver evaluations and recalc flags that should be redundant in the new depsgraph, and were incorrectly affecting the evaluated scene in a permanent way. Still two cases that could be removed if the depsgraph is improved, in BKE_object_handle_data_update and BKE_cachefile_update_frame. For physics subframe interpolation there are also still calls to BKE_object_where_is_calc that should ideally be removed as well, though they are not known to cause keyframing bugs. Differential Revision: https://developer.blender.org/D4274
This commit is contained in:
		@@ -399,13 +399,6 @@ static void fluid_init_all_channels(bContext *C, Object *UNUSED(fsDomain), Fluid
 | 
			
		||||
 | 
			
		||||
		eval_time = domainSettings->bakeStart + i;
 | 
			
		||||
 | 
			
		||||
		/* XXX: This can't be used due to an anim sys optimization that ignores recalc object animation,
 | 
			
		||||
		 * leaving it for the depgraph (this ignores object animation such as modifier properties though... :/ )
 | 
			
		||||
		 * --> BKE_animsys_evaluate_all_animation(CTX_data_main(C), eval_time);
 | 
			
		||||
		 * This doesn't work with drivers:
 | 
			
		||||
		 * --> BKE_animsys_evaluate_animdata(&fsDomain->id, fsDomain->adt, eval_time, ADT_RECALC_ALL);
 | 
			
		||||
		 */
 | 
			
		||||
 | 
			
		||||
		/* Modifying the global scene isn't nice, but we can do it in
 | 
			
		||||
		 * this part of the process before a threaded job is created */
 | 
			
		||||
		scene->r.cfra = (int)eval_time;
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user