archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

GPUSelect: Don't read depth on every draw

Browse Source 
If the draw uses the same id as the previous draw, there is no need to read the depth
buffer at this point, avoiding a CPU-GPU sync bubble.

Fixes T62511 Selection is significantly slower in production scenes.
With this patch glReadPixels is not the bottleneck. Regular drawing Is still very
slow so I would suggest fixing the regular drawing first before trying to
improve the selection algorithm.
This commit is contained in:
Clément Foucault
2019-04-26 15:33:16 +02:00
parent 50d75cd528
commit 86914e7133
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/gpu/intern/gpu_select_pick.c
View File

@@ -479,7 +479,14 @@ static void gpu_select_load_id_pass_nearest(const DepthBufCache *rect_prev,
bool gpu_select_pick_load_id(uint id) bool gpu_select_pick_load_id(uint id)
{ {
GPUPickState *ps = &g_pick_state; GPUPickState *ps = &g_pick_state;
if (ps->gl.is_init) { if (ps->gl.is_init) {
if (id == ps->gl.prev_id) {
/* No need to read if we are still drawing for the same id since
* all these depths will be merged / deduplicated in the end. */
return true;
}
const uint rect_len = ps->src.rect_len; const uint rect_len = ps->src.rect_len;
glReadPixels(UNPACK4(ps->gl.clip_readpixels), glReadPixels(UNPACK4(ps->gl.clip_readpixels),
GL_DEPTH_COMPONENT, GL_DEPTH_COMPONENT,