- use clear, set, add, enable, disable and toggle as a prefix in operator names
- use select as a suffix eg UV_OT_loop_select -> UV_OT_select_loop - Each select all operator was using slightly different wording... select_all, deselect_all, de_select_all, select_de_select_all -> select_all_toggle - selection -> select - POSE_OT_select_connected -> POSE_OT_select_linked to match other operators - NODE_OT_delete_selection -> NODE_OT_delete since its not used in other operators - ANIM_OT_previewrange_define -> ANIM_OT_previewrange_set to match other operators - NODE_OT_fit_all -> NODE_OT_view_all to match other operators - View2D_OT_* -> VIEW2D_OT_* to match VIEW3D - View2D_OT_view_downscroll -> VIEW2D_OT_scroll_down more logical - removed MARKER_OT_mouseselect_extend and made extend a boolean property of MARKER_OT_mouseselect - MARKER_OT_mouseselect -> MARKER_OT_select - GROUP_OT_group_remove -> GROUP_OT_objects_remove more logical since its removing objects from groups - MESH_OT_removedoublesflag -> MESH_OT_remove_doubles - redundant words MESH_OT_split_mesh -> MESH_OT_split, OBJECT_OT_object_delete -> OBJECT_OT_delete renamed selection operator properties extend_select -> extend column_select -> column select_children_only -> children_only ... Since these are all in the context of selection operators there is no need for the extra 'select' in the property name. Updated docs http://www.graphicall.org/ftp/ideasman42/html/bpyoperator-module.html
This commit is contained in:
@@ -176,11 +176,11 @@ static int graphkeys_deselectall_exec(bContext *C, wmOperator *op)
|
||||
return OPERATOR_FINISHED;
|
||||
}
|
||||
|
||||
void GRAPHEDIT_OT_keyframes_deselectall (wmOperatorType *ot)
|
||||
void GRAPHEDIT_OT_keyframes_select_all_toggle (wmOperatorType *ot)
|
||||
{
|
||||
/* identifiers */
|
||||
ot->name= "Select All";
|
||||
ot->idname= "GRAPHEDIT_OT_keyframes_deselectall";
|
||||
ot->idname= "GRAPHEDIT_OT_keyframes_select_all_toggle";
|
||||
|
||||
/* api callbacks */
|
||||
ot->exec= graphkeys_deselectall_exec;
|
||||
@@ -307,11 +307,11 @@ static int graphkeys_borderselect_exec(bContext *C, wmOperator *op)
|
||||
return OPERATOR_FINISHED;
|
||||
}
|
||||
|
||||
void GRAPHEDIT_OT_keyframes_borderselect(wmOperatorType *ot)
|
||||
void GRAPHEDIT_OT_keyframes_select_border(wmOperatorType *ot)
|
||||
{
|
||||
/* identifiers */
|
||||
ot->name= "Border Select";
|
||||
ot->idname= "GRAPHEDIT_OT_keyframes_borderselect";
|
||||
ot->idname= "GRAPHEDIT_OT_keyframes_select_border";
|
||||
|
||||
/* api callbacks */
|
||||
ot->invoke= WM_border_select_invoke;
|
||||
@@ -854,7 +854,7 @@ static int graphkeys_clickselect_invoke(bContext *C, wmOperator *op, wmEvent *ev
|
||||
|
||||
/* select mode is either replace (deselect all, then add) or add/extend */
|
||||
// XXX this is currently only available for normal select only
|
||||
if (RNA_boolean_get(op->ptr, "extend_select"))
|
||||
if (RNA_boolean_get(op->ptr, "extend"))
|
||||
selectmode= SELECT_INVERT;
|
||||
else
|
||||
selectmode= SELECT_REPLACE;
|
||||
@@ -872,7 +872,7 @@ static int graphkeys_clickselect_invoke(bContext *C, wmOperator *op, wmEvent *ev
|
||||
|
||||
graphkeys_select_leftright(&ac, RNA_enum_get(op->ptr, "left_right"), selectmode);
|
||||
}
|
||||
else if (RNA_boolean_get(op->ptr, "column_select")) {
|
||||
else if (RNA_boolean_get(op->ptr, "column")) {
|
||||
/* select all the keyframes that occur on the same frame as where the mouse clicked */
|
||||
float x;
|
||||
|
||||
@@ -905,8 +905,8 @@ void GRAPHEDIT_OT_keyframes_clickselect (wmOperatorType *ot)
|
||||
/* id-props */
|
||||
// XXX should we make this into separate operators?
|
||||
RNA_def_enum(ot->srna, "left_right", NULL /* XXX prop_graphkeys_clickselect_items */, 0, "Left Right", ""); // ALTKEY
|
||||
RNA_def_boolean(ot->srna, "extend_select", 0, "Extend Select", ""); // SHIFTKEY
|
||||
RNA_def_boolean(ot->srna, "column_select", 0, "Column Select", ""); // CTRLKEY
|
||||
RNA_def_boolean(ot->srna, "extend", 0, "Extend Select", ""); // SHIFTKEY
|
||||
RNA_def_boolean(ot->srna, "column", 0, "Column Select", ""); // CTRLKEY
|
||||
}
|
||||
|
||||
/* ************************************************************************** */
|
||||
|
||||
Reference in New Issue
Block a user