archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

===Python API===

Browse Source 
Bugfix #4690: BonesDict_repr() had a string overflow for really complicated
armatures.  Added a string length check and terminate before overflowing.
This commit is contained in:
Ken Hughes
2006-07-14 14:48:45 +00:00
parent a7b3203e31
commit a33bd50108
1 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
source/blender/python/api2_2x/Armature.c
View File

@@ -170,25 +170,38 @@ static int BonesDict_InitEditBones(BPy_BonesDict *self)
//This is the string representation of the object
static PyObject *BonesDict_repr(BPy_BonesDict *self)
{
char str[4096];
char str[2048];
PyObject *key, *value;
int pos = 0;
char *p = str;
char *keys, *vals;
p += sprintf(str, "[Bone Dict: {");
if (self->editmode_flag){
while (PyDict_Next(self->editbonesMap, &pos, &key, &value)) {
p += sprintf(p, "%s : %s, ", PyString_AsString(key),
PyString_AsString(value->ob_type->tp_repr(value)));
keys = PyString_AsString(key);
vals = PyString_AsString(value->ob_type->tp_repr(value));
if( strlen(str) + strlen(keys) + strlen(vals) < sizeof(str)-20 )
p += sprintf(p, "%s : %s, ", keys, vals );
else {
p += sprintf(p, "...." );
break;
}
}
}else{
while (PyDict_Next(self->bonesMap, &pos, &key, &value)) {
p += sprintf(p, "%s : %s, ", PyString_AsString(key),
PyString_AsString(value->ob_type->tp_repr(value)));
keys = PyString_AsString(key);
vals = PyString_AsString(value->ob_type->tp_repr(value));
if( strlen(str) + strlen(keys) + strlen(vals) < sizeof(str)-20 )
p += sprintf(p, "%s : %s, ", keys, vals );
else {
p += sprintf(p, "...." );
break;
}
}
}
p += sprintf(p, "}]\n");
sprintf(p, "}]");
return PyString_FromString(str);
}