archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Cleanup: avoid error prone struct declarations in C++

Browse Source 
Reference struct members by name instead relying on their order.
This also simplifies moving back to named members when all compilers
we use support them.
This commit is contained in:
Campbell Barton
2021-11-08 16:54:20 +11:00
parent de581a2302
commit c3f5fca8a2
8 changed files with 35 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source/blender/blenkernel/intern/mesh.cc
View File

@@ -1138,8 +1138,12 @@ BMesh *BKE_mesh_to_bmesh(Mesh *me,
const bool add_key_index,
const struct BMeshCreateParams *params)
{
struct BMeshFromMeshParams bmfmp = {false, add_key_index, true, ob->shapenr};
return BKE_mesh_to_bmesh_ex(me, params, &bmfmp);
BMeshFromMeshParams bmesh_from_mesh_params{};
bmesh_from_mesh_params.calc_face_normal = false;
bmesh_from_mesh_params.add_key_index = add_key_index;
bmesh_from_mesh_params.use_shapekey = true;
bmesh_from_mesh_params.active_shapekey = ob->shapenr;
return BKE_mesh_to_bmesh_ex(me, params, &bmesh_from_mesh_params);
}
Mesh *BKE_mesh_from_bmesh_nomain(BMesh *bm,