archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Cleanup: avoid positional struct initialization

Browse Source 
When moving to C++ field for initialization was removed.
Favor assignments to field names as it reads better and avoids bugs if
files are ever re-arranged as well as mistakes (see T94784).

Note that the generated optimized output is identical with GCC11.
This commit is contained in:
Campbell Barton
2022-01-24 14:09:31 +11:00
parent abf30007ab
commit c69a581c0b
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/modifiers/intern/MOD_weld.cc
View File

@@ -386,7 +386,10 @@ static Vector<WeldVert> weld_vert_ctx_alloc_and_setup(Span<int> vert_dest_map,
for (const int i : vert_dest_map.index_range()) { for (const int i : vert_dest_map.index_range()) {
if (vert_dest_map[i] != OUT_OF_CONTEXT) { if (vert_dest_map[i] != OUT_OF_CONTEXT) {
wvert.append({vert_dest_map[i], i}); WeldVert wv{};
wv.vert_dest = vert_dest_map[i];
wv.vert_orig = i;
wvert.append(wv);
} }
} }
return wvert; return wvert;