archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

perf improvement for array modifiers

Browse Source
This commit is contained in:
Andrew Wiggin
2011-10-27 17:39:15 +00:00
parent dbe1c4277a
commit c914b11614
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
source/blender/modifiers/intern/MOD_array.c
View File

@@ -392,6 +392,15 @@ static DerivedMesh *arrayModifier_doArray(ArrayModifierData *amd,
if(count < 1) if(count < 1)
count = 1; count = 1;
/* BMESH_TODO: bumping up the stack level avoids computing the normals
after every top-level operator execution (and this modifier has the
potential to execute a *lot* of top-level BMOps. There should be a
cleaner way to do this. One possibility: a "mirror" BMOp would
certainly help by compressing it all into one top-level BMOp that
executes a lot of second-level BMOps. */
BMO_push(em->bm, NULL);
bmesh_begin_edit(em->bm, 0);
BMO_Init_Op(&weldop, "weldverts"); BMO_Init_Op(&weldop, "weldverts");
BMO_InitOpf(em->bm, &op, "dupe geom=%avef"); BMO_InitOpf(em->bm, &op, "dupe geom=%avef");
oldop = op; oldop = op;
@@ -474,6 +483,10 @@ static DerivedMesh *arrayModifier_doArray(ArrayModifierData *amd,
BMO_Finish_Op(em->bm, &weldop); BMO_Finish_Op(em->bm, &weldop);
/* Bump the stack level back down to match the adjustment up above */
bmesh_end_edit(em->bm, 0);
BMO_pop(em->bm);
BMEdit_RecalcTesselation(em); BMEdit_RecalcTesselation(em);
cddm = CDDM_from_BMEditMesh(em, NULL, 0); cddm = CDDM_from_BMEditMesh(em, NULL, 0);