archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Fix possible pointer being freed without being allocated in pygpu module

Browse Source 
The `clear` method can be called before dealloc, which can
mislead buffer ownership.
This commit is contained in:
Germano Cavalcante
2022-04-12 20:52:19 -03:00
parent 9bc678969a
commit cd4a9c488f
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/python/gpu/gpu_py_buffer.c
View File

@@ -277,7 +277,10 @@ static int pygpu_buffer__tp_traverse(BPyGPUBuffer *self, visitproc visit, void *
static int pygpu_buffer__tp_clear(BPyGPUBuffer *self) static int pygpu_buffer__tp_clear(BPyGPUBuffer *self)
{ {
Py_CLEAR(self->parent); if (self->parent) {
Py_CLEAR(self->parent);
self->buf.as_void = NULL;
}
return 0; return 0;
} }
@@ -287,7 +290,7 @@ static void pygpu_buffer__tp_dealloc(BPyGPUBuffer *self)
PyObject_GC_UnTrack(self); PyObject_GC_UnTrack(self);
Py_CLEAR(self->parent); Py_CLEAR(self->parent);
} }
else { else if (self->buf.as_void) {
MEM_freeN(self->buf.as_void); MEM_freeN(self->buf.as_void);
} }