archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Fix T89204: slow repeated rendering with GPUOffscreen.draw_view3d

Browse Source 
Cache the GPUViewport so the framebuffers and associated textures are not
reallocated each time.
This commit is contained in:
Brecht Van Lommel
2021-06-16 20:07:24 +02:00
parent a1cc7042a7
commit d03b26edbd
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
source/blender/python/gpu/gpu_py_offscreen.c
View File

@@ -44,6 +44,7 @@
#include "GPU_context.h"
#include "GPU_framebuffer.h"
#include "GPU_texture.h"
#include "GPU_viewport.h"
#include "ED_view3d.h"
#include "ED_view3d_offscreen.h"
@@ -342,6 +343,10 @@ static PyObject *pygpu_offscreen_draw_view3d(BPyGPUOffScreen *self, PyObject *ar
GPU_offscreen_bind(self->ofs, true);
if (!self->viewport) {
self->viewport = GPU_viewport_create();
}
ED_view3d_draw_offscreen(depsgraph,
scene,
v3d->shading.type,
@@ -357,7 +362,7 @@ static PyObject *pygpu_offscreen_draw_view3d(BPyGPUOffScreen *self, PyObject *ar
false,
true,
self->ofs,
NULL);
self->viewport);
GPU_offscreen_unbind(self->ofs, true);
@@ -378,6 +383,10 @@ static PyObject *pygpu_offscreen_free(BPyGPUOffScreen *self)
{
BPY_GPU_OFFSCREEN_CHECK_OBJ(self);
if (self->viewport) {
GPU_viewport_free(self->viewport);
self->viewport = NULL;
}
GPU_offscreen_free(self->ofs);
self->ofs = NULL;
Py_RETURN_NONE;
@@ -386,6 +395,9 @@ static PyObject *pygpu_offscreen_free(BPyGPUOffScreen *self)
static void BPyGPUOffScreen__tp_dealloc(BPyGPUOffScreen *self)
{
if (self->viewport) {
GPU_viewport_free(self->viewport);
}
if (self->ofs) {
GPU_offscreen_free(self->ofs);
}
@@ -456,6 +468,7 @@ PyObject *BPyGPUOffScreen_CreatePyObject(GPUOffScreen *ofs)
self = PyObject_New(BPyGPUOffScreen, &BPyGPUOffScreen_Type);
self->ofs = ofs;
self->viewport = NULL;
return (PyObject *)self;
}

4
source/blender/python/gpu/gpu_py_offscreen.h
View File

@@ -26,8 +26,12 @@ extern PyTypeObject BPyGPUOffScreen_Type;
#define BPyGPUOffScreen_Check(v) (Py_TYPE(v) == &BPyGPUOffScreen_Type)
struct GPUOffscreen;
struct GPUViewport;
typedef struct BPyGPUOffScreen {
PyObject_HEAD struct GPUOffScreen *ofs;
struct GPUViewport *viewport;
} BPyGPUOffScreen;
PyObject *BPyGPUOffScreen_CreatePyObject(struct GPUOffScreen *ofs) ATTR_NONNULL(1);