archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Cleanup: Remove bNodeType flag from base registration functions

Browse Source 
This flag is only used a few small cases, so instead
of setting the flag for every node only set the
required flag for the nodes that require it.

Mostly the flag is used to set `ntype.flag = NODE_PREVIEW`
For nodes that should have previews by default which
is only some compositor nodes and some texture nodes.

The frame node also sets the `NODE_BACKGROUND` flag.

All other nodes were setting a flag of 0 which has no purpose.

Reviewed By: JacquesLucke

Differential Revision: https://developer.blender.org/D13699
This commit is contained in:
Aaron Carlisle
2022-01-03 19:32:33 -05:00
committed by Aaron Carlisle
parent 9793bc30ce
commit d3ad04172d
377 changed files with 442 additions and 468 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/nodes/function/node_function_util.cc
View File

@@ -31,9 +31,9 @@ static bool fn_node_poll_default(bNodeType *UNUSED(ntype),
return true;
}
void fn_node_type_base(bNodeType *ntype, int type, const char *name, short nclass, short flag)
void fn_node_type_base(bNodeType *ntype, int type, const char *name, short nclass)
{
node_type_base(ntype, type, name, nclass, flag);
node_type_base(ntype, type, name, nclass);
ntype->poll = fn_node_poll_default;
ntype->insert_link = node_insert_link_default;
ntype->gather_link_search_ops = blender::nodes::search_link_ops_for_basic_node;