archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Fix T87567: Crash adding item in empty attribute search

Browse Source 
The function applying the search used the dummy search info for when
the item doesn't exist even when there was no UI data associated with
the node at all.

A fix is to only add the search menu when there is attribute info
stored for the node. This is something I wanted to do anyway, since
it makes it look more purposeful when there are no attribute info
for a node, less like a bug.

Differential Revision: https://developer.blender.org/D11016
This commit is contained in:
Hans Goudey
2021-04-19 12:31:18 -05:00
parent b8b7b47a00
commit d7caae56c4
4 changed files with 32 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/editors/space_node/node_intern.h
View File

@@ -310,7 +310,8 @@ void NODE_OT_cryptomatte_layer_add(struct wmOperatorType *ot);
void NODE_OT_cryptomatte_layer_remove(struct wmOperatorType *ot);
/* node_geometry_attribute_search.cc */
void node_geometry_add_attribute_search_button(const struct bNodeTree *node_tree,
void node_geometry_add_attribute_search_button(const struct bContext *C,
const struct bNodeTree *node_tree,
const struct bNode *node,
struct PointerRNA *socket_ptr,
struct uiLayout *layout);