archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Refactor: Simplify ID Property freeing

Browse Source 
This also makes `IDP_CopyProperty` the "opposite"
of `IDP_FreeProperty`, which is what I'd expect.

Two refactoring steps:
* rename IDP_FreeProperty to IDP_FreePropertyContent
* new IDP_FreeProperty function that actually frees the property

Reviewers: brecht

Differential Revision: https://developer.blender.org/D4872
This commit is contained in:
Jacques Lucke
2019-05-16 14:11:11 +02:00
parent c0d743238d
commit db5120603f
37 changed files with 23 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/blenkernel/intern/writeffmpeg.c
View File

@@ -1616,7 +1616,7 @@ static void ffmpeg_set_expert_options(RenderData *rd)
int codec_id = rd->ffcodecdata.codec;
if (rd->ffcodecdata.properties) {
IDP_FreeProperty(rd->ffcodecdata.properties);
IDP_FreePropertyContent(rd->ffcodecdata.properties);
}
if (codec_id == AV_CODEC_ID_H264) {
@@ -1680,7 +1680,7 @@ void BKE_ffmpeg_preset_set(RenderData *rd, int preset)
int isntsc = (rd->frs_sec != 25);
if (rd->ffcodecdata.properties) {
IDP_FreeProperty(rd->ffcodecdata.properties);
IDP_FreePropertyContent(rd->ffcodecdata.properties);
}
switch (preset) {