archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Fix 8 memory leaks from bad PyList_Append use

Browse Source
This commit is contained in:
Campbell Barton
2015-01-04 20:33:29 +11:00
parent e0db0f84ac
commit de6b546e15
6 changed files with 33 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/freestyle/intern/python/BPy_SShape.cpp
View File

@@ -227,13 +227,14 @@ PyDoc_STRVAR(SShape_vertices_doc,
static PyObject *SShape_vertices_get(BPy_SShape *self, void *UNUSED(closure))
{
PyObject *py_vertices = PyList_New(0);
vector< SVertex * > vertices = self->ss->getVertexList();
vector< SVertex * >::iterator it;
PyObject *py_vertices = PyList_New(vertices.size());
unsigned int i = 0;
for (it = vertices.begin(); it != vertices.end(); it++) {
PyList_Append(py_vertices, BPy_SVertex_from_SVertex(*(*it)));
PyList_SET_ITEM(py_vertices, i++, BPy_SVertex_from_SVertex(*(*it)));
}
return py_vertices;
@@ -246,13 +247,14 @@ PyDoc_STRVAR(SShape_edges_doc,
static PyObject *SShape_edges_get(BPy_SShape *self, void *UNUSED(closure))
{
PyObject *py_edges = PyList_New(0);
vector< FEdge * > edges = self->ss->getEdgeList();
vector< FEdge * >::iterator it;
PyObject *py_edges = PyList_New(edges.size());
unsigned int i = 0;
for (it = edges.begin(); it != edges.end(); it++) {
PyList_Append(py_edges, Any_BPy_FEdge_from_FEdge(*(*it)));
PyList_SET_ITEM(py_edges, i++, Any_BPy_FEdge_from_FEdge(*(*it)));
}
return py_edges;