archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Fix T65092: error with gizmos using freed keymaps

Browse Source 
Caused by 5adfc51a0f, sharing keymaps caused changing tools to
unregister gizmos and remove their keymaps.

Workaround for now by not removing the keymap.
This commit is contained in:
Campbell Barton
2019-05-25 12:37:25 +10:00
parent 8e812504b4
commit e12f42946f
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/windowmanager/gizmo/intern/wm_gizmo_group.c
View File

@@ -921,8 +921,12 @@ void WM_gizmomaptype_group_unlink(bContext *C,
WM_gizmomaptype_group_free(gzgt_ref); WM_gizmomaptype_group_free(gzgt_ref);
} }
/* TODO(campbell): Gizmos may share keymaps, for now don't
* remove however we could flag them as temporary/owned by the gizmo. */
#if 0
/* Note, we may want to keep this keymap for editing */ /* Note, we may want to keep this keymap for editing */
WM_keymap_remove(gzgt->keyconf, gzgt->keymap); WM_keymap_remove(gzgt->keyconf, gzgt->keymap);
#endif
BLI_assert(WM_gizmomaptype_group_find_ptr(gzmap_type, gzgt) == NULL); BLI_assert(WM_gizmomaptype_group_find_ptr(gzmap_type, gzgt) == NULL);
} }