Cleanup: use const variables where possible in the Python API

source/blender/python/mathutils/mathutils.c

@@ -208,7 +208,7 @@ int mathutils_array_parse(
 
   if (size != -1) {
     if (flag & MU_ARRAY_ZERO) {
-      int size_left = array_max - size;
+      const int size_left = array_max - size;
       if (size_left) {
         memset(&array[size], 0, sizeof(float) * size_left);
       }
@@ -541,9 +541,9 @@ int EXPP_FloatsAreEqual(float af, float bf, int maxDiff)
 {
   /* solid, fast routine across all platforms
    * with constant time behavior */
-  int ai = *(int *)(&af);
-  int bi = *(int *)(&bf);
-  int test = SIGNMASK(ai ^ bi);
+  const int ai = *(int *)(&af);
+  const int bi = *(int *)(&bf);
+  const int test = SIGNMASK(ai ^ bi);
   int diff, v1, v2;
 
   assert((0 == test) || (0xFFFFFFFF == test));

source/blender/python/mathutils/mathutils_Color.c

@@ -749,7 +749,7 @@ PyDoc_STRVAR(Color_channel_hsv_v_doc, "HSV Value component in [0, 1].\n\n:type:
 static PyObject *Color_channel_hsv_get(ColorObject *self, void *type)
 {
   float hsv[3];
-  int i = POINTER_AS_INT(type);
+  const int i = POINTER_AS_INT(type);
 
   if (BaseMath_ReadCallback(self) == -1) {
     return NULL;
@@ -763,7 +763,7 @@ static PyObject *Color_channel_hsv_get(ColorObject *self, void *type)
 static int Color_channel_hsv_set(ColorObject *self, PyObject *value, void *type)
 {
   float hsv[3];
-  int i = POINTER_AS_INT(type);
+  const int i = POINTER_AS_INT(type);
   float f = PyFloat_AsDouble(value);
 
   if (f == -1 && PyErr_Occurred()) {

source/blender/python/mathutils/mathutils_Matrix.c

@@ -809,7 +809,7 @@ static PyObject *C_Matrix_OrthoProjection(PyObject *cls, PyObject *args)
   else {
     /* arbitrary plane */
 
-    int vec_size = (matSize == 2 ? 2 : 3);
+    const int vec_size = (matSize == 2 ? 2 : 3);
     float tvec[4];
 
     if (mathutils_array_parse(tvec,
@@ -2156,7 +2156,8 @@ static PyObject *Matrix_str(MatrixObject *self)
   for (col = 0; col < self->num_col; col++) {
     maxsize[col] = 0;
     for (row = 0; row < self->num_row; row++) {
-      int size = BLI_snprintf(dummy_buf, sizeof(dummy_buf), "%.4f", MATRIX_ITEM(self, row, col));
+      const int size = BLI_snprintf(
+          dummy_buf, sizeof(dummy_buf), "%.4f", MATRIX_ITEM(self, row, col));
       maxsize[col] = max_ii(maxsize[col], size);
     }
   }

source/blender/python/mathutils/mathutils_Vector.c

@@ -356,7 +356,7 @@ PyDoc_STRVAR(Vector_normalize_doc,
              "      however 4D Vectors w axis is left untouched.\n");
 static PyObject *Vector_normalize(VectorObject *self)
 {
-  int size = (self->size == 4 ? 3 : self->size);
+  const int size = (self->size == 4 ? 3 : self->size);
   if (BaseMath_ReadCallback_ForWrite(self) == -1) {
     return NULL;
   }
@@ -2027,7 +2027,7 @@ static PyObject *Vector_richcmpr(PyObject *objectA, PyObject *objectB, int compa
 {
   VectorObject *vecA = NULL, *vecB = NULL;
   int result = 0;
-  double epsilon = 0.000001f;
+  const double epsilon = 0.000001f;
   double lenA, lenB;
 
   if (!VectorObject_Check(objectA) || !VectorObject_Check(objectB)) {

source/blender/python/mathutils/mathutils_bvhtree.c

@@ -589,7 +589,7 @@ static PyObject *py_bvhtree_overlap(PyBVHTree *self, PyBVHTree *other)
     /* pass */
   }
   else {
-    bool use_unique = (self->orig_index || other->orig_index);
+    const bool use_unique = (self->orig_index || other->orig_index);
     GSet *pair_test = use_unique ?
                           BLI_gset_new_ex(overlap_hash, overlap_cmp, __func__, overlap_len) :
                           NULL;
@@ -1037,7 +1037,7 @@ static Mesh *bvh_get_mesh(const char *funcname,
 {
   Object *ob_eval = DEG_get_evaluated_object(depsgraph, ob);
   /* we only need minimum mesh data for topology and vertex locations */
-  CustomData_MeshMasks data_masks = CD_MASK_BAREMESH;
+  const CustomData_MeshMasks data_masks = CD_MASK_BAREMESH;
   const bool use_render = DEG_get_mode(depsgraph) == DAG_EVAL_RENDER;
   *r_free_mesh = false;
 

source/blender/python/mathutils/mathutils_geometry.c

@@ -315,7 +315,7 @@ static PyObject *M_Geometry_intersect_tri_tri_2d(PyObject *UNUSED(self), PyObjec
     }
   }
 
-  bool ret = isect_tri_tri_v2(UNPACK3(tri_pair[0]), UNPACK3(tri_pair[1]));
+  const bool ret = isect_tri_tri_v2(UNPACK3(tri_pair[0]), UNPACK3(tri_pair[1]));
   return PyBool_FromLong(ret);
 }
 
@@ -492,7 +492,7 @@ static PyObject *M_Geometry_intersect_line_plane(PyObject *UNUSED(self), PyObjec
   PyObject *py_line_a, *py_line_b, *py_plane_co, *py_plane_no;
   float line_a[3], line_b[3], plane_co[3], plane_no[3];
   float isect[3];
-  bool no_flip = false;
+  const bool no_flip = false;
 
   if (!PyArg_ParseTuple(args,
                         "OOOO|O&:intersect_line_plane",

source/blender/python/mathutils/mathutils_kdtree.c

@@ -191,7 +191,7 @@ static int py_find_nearest_cb(void *user_data, int index, const float co[3], flo
 
   if (result) {
     bool use_node;
-    int ok = PyC_ParseBool(result, &use_node);
+    const int ok = PyC_ParseBool(result, &use_node);
     Py_DECREF(result);
     if (ok) {
       return (int)use_node;