archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

BMesh: BM_face_exists no longer uses return arg

Browse Source 
Just return the face or NULL, like BM_edge_exists(),
Also for BM_face_exists_overlap & bm_face_exists_tri_from_loop_vert.
No functional changes.

Old code did some partial overlap checks where this made some sense,
but it's since been removed.
This commit is contained in:
Campbell Barton
2016-11-14 04:10:47 +11:00
parent 1b1d6ce131
commit fc9fa07c0e
12 changed files with 34 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/python/bmesh/bmesh_py_types.c
View File

@@ -2233,7 +2233,7 @@ static PyObject *bpy_bmfaceseq_new(BPy_BMElemSeq *self, PyObject *args)
}
/* check if the face exists */
if (BM_face_exists(vert_array, vert_seq_len, NULL)) {
if (BM_face_exists(vert_array, vert_seq_len) != NULL) {
PyErr_SetString(PyExc_ValueError,
"faces.new(verts): face already exists");
goto cleanup;
@@ -2426,7 +2426,8 @@ static PyObject *bpy_bmfaceseq_get__method(BPy_BMElemSeq *self, PyObject *args)
return NULL;
}
if (BM_face_exists(vert_array, vert_seq_len, &f)) {
f = BM_face_exists(vert_array, vert_seq_len);
if (f != NULL) {
ret = BPy_BMFace_CreatePyObject(bm, f);
}
else {