Commit Graph

73 Commits

Author SHA1 Message Date
cccd4b72e5 fix memory leak in rip tool (again own fault). 2012-04-23 15:26:06 +00:00
eff325a98c minor changes to rip internals
- check if vertex ripping has no effect.
- no need to flush selection for vertex rip.
2012-04-23 15:18:12 +00:00
cb91c5d7b2 rip was incorrectly giving an error when ripping a vertex from a face fan (own mistake). 2012-04-23 14:57:47 +00:00
16ff7e40e6 code cleanup: change C naming convention (so py and C api match), eg:
C: BM_face_calc_area(f), Py: BMFace.calc_area()
2012-04-23 01:19:50 +00:00
8765dfccf7 style cleanup: correct typos 2012-04-21 14:14:58 +00:00
96b024333e fix [#31047] ctrl+mouse select in edit-mode does not select external object
fix [#30535] Shortest Path Select not working well in vertex mode.

regression from after bmesh merge, Ctrl+Right mouse for selecting shortest path is meant for edge mode only.
2012-04-21 12:14:07 +00:00
f910abadda fix error in recent rip refactor, also add comment. 2012-04-21 06:42:21 +00:00
15eb3452ec style cleanup: pep8, also quiet compiler warning. 2012-04-20 18:50:18 +00:00
b26865ba99 code cleanup: prefer BM_face/edge/vert_select_set() over BM_elem_select_set() when the type is known (saves switch statement check on the type).
Add asserts so the correct types are ensured.
2012-04-20 16:55:47 +00:00
f627745053 aparently yards are not used a lot, suppress their use in button display (input still knows about them) - was reported as a bug.
also fix minor rip bug where active selection was lost.
2012-04-20 14:59:24 +00:00
380e6c2a58 refactor rip tool out into vert/edge functions, was getting too unweildy having them mixed in. 2012-04-20 14:36:06 +00:00
384f87cd1c rip tool wasnt working on a single edge selection in some cases (own error in recent fix). 2012-04-19 23:16:57 +00:00
741a177a74 bmesh: improve rip tool
- When the rip extends into a fan, pick the opposite edge in the fan (rather then 2 along)
- When stepping over the fan to find the rip edge, walk in the direction closest to the mouse (generally works nicer)
2012-04-19 21:47:32 +00:00
e730c1af6d committed check by mistake, its not needed. 2012-04-19 17:26:22 +00:00
a82eaf36ca bmesh rip: when there are selected faces call region_to_loop before ripping. gives better results then previous fix when there are selected faces as apart of an edge selection. 2012-04-19 16:57:50 +00:00
bea1a12751 fix [#31015] Rip has weird results in vertex selection mode vs face 2012-04-19 16:20:07 +00:00
b40476455e code cleanup: remove unused BMesh args. 2012-04-19 14:38:09 +00:00
475ecbb0ce remove BM_ITER, BM_ITER_INDEX macros, use ELEM or MESH variants only (the maceros had unused args in both cases). 2012-04-19 13:47:58 +00:00
75b869e428 style cleanup: BM_ITER / BM_ITER_INDEX / BMO_ITER 2012-04-19 11:44:12 +00:00
f1ececaabb code cleanup: replace use of BM_edge_face_count with BM_edge_is_manifold and BM_edge_is_boundary 2012-04-18 06:44:48 +00:00
830013aabe fix error in single vertex ripping where the edit-selection could be left on unselected verts or not set on the newly ripped vertex.
also some corrections to comments.
2012-04-17 18:36:29 +00:00
1d6a5a4aa4 fix [#30970] Rip Tool: selecting the side of edges works incorrectly 2012-04-17 18:14:31 +00:00
09f722740f move rip out into its own file 2012-04-17 10:25:23 +00:00