b659d1a560
Cleanup: spelling in comments
2021-09-23 22:08:02 +10:00
0950cfd9d5
PyAPI: add read-only 'is_valid' attribute to mathutils types
...
There was no convenient way to check if the owner
of a mathutils type was valid.
Added to support issue reported in T91111.
2021-09-03 21:21:44 +10:00
c741558509
Cleanup: spelling in comments
2021-08-12 14:34:43 +10:00
6fe00939b0
PyAPI: resolve build error with Python 3.10
...
Resolves T89931
2021-08-09 22:55:41 +10:00
6deb37474e
Cleanup: spelling in comments
2021-08-09 22:55:38 +10:00
ced94bc11c
Cleanup: code comments punctuation / spacing
2021-07-23 17:03:51 +10:00
c3a400b73f
Cleanup: use single back-tick quoting in comments
...
While doxygen supports both, conform to our style guide.
Note that single back-tick's are already used in a majority of comments.
2021-07-20 22:58:14 +10:00
ff01070b5c
Cleanup: minor correction to delaunay_2d_cdt doc-string
...
Use more conventional syntax for default arguments.
2021-07-19 11:57:28 +10:00
76f0ef294a
Update documentation string for mathutils.geometry.delaunay_2d_cdt.
2021-07-18 15:24:12 -04:00
72d1ddfc9c
Make it optional to track input->output mapping in delaunay_2d_calc.
...
Some uses of delaunay_2d_calc don't need to know the original verts,
edges, and faces that correspond to output elements.
This change adds a "need_ids" value to the CDT input spec, default true,
which tracks the input ids only when true.
The python api mathutils.geometry.delaunay_2d_cdt gets an optional
final bool argument that is the value of need_ids. If the argument
is not supplied, it is true by default, so this won't break old uses
of the API.
On a sample text test, not tracking ids save about 30% of the runtime.
For most inputs the difference will not be so dramatic: it only really
kicks in if there are a lot of holes.
2021-07-18 15:10:34 -04:00
bf5b1fa726
Cleanup: remove redundant parentheses
2021-07-16 11:45:52 +10:00
8e8a6b80cf
Cleanup: replace BLI_assert(!"text") with BLI_assert_msg(0, "text")
...
This shows the text as part of the assertion message.
2021-07-15 18:29:01 +10:00
nutti
695e025c82
Docs: Fix minor incorrect syntax errors
...
This patch fixes the incorrect syntax in documentations.
Reviewed By: Blendify
Differential Revision: https://developer.blender.org/D11822
2021-07-07 19:41:46 -04:00
f0f7282d9d
Cleanup: spelling in comments
2021-07-05 15:54:57 +10:00
9b89de2571
Cleanup: consistent use of tags: NOTE/TODO/FIXME/XXX
...
Also use doxy style function reference `#` prefix chars when
referencing identifiers.
2021-07-04 00:43:40 +10:00
f1e4903854
Cleanup: full sentences in comments, improve comment formatting
2021-06-26 21:50:48 +10:00
6570159929
Cleanup: update clang-format so PyObject_HEAD indents properly
2021-06-24 17:12:04 +10:00
4b9ff3cd42
Cleanup: comment blocks, trailing space in comments
2021-06-24 15:59:34 +10:00
Leon Zandman
c317f111c1
Cleanup: Spelling Mistakes
...
This patch fixes many minor spelling mistakes, all in comments or
console output. Mostly contractions like can't, won't, don't, its/it's,
etc.
Differential Revision: https://developer.blender.org/D11663
Reviewed by Harley Acheson
2021-06-22 10:54:50 -07:00
f29a738e23
PyAPI: use keyword only arguments
...
Use keyword only arguments for the following functions.
- addon_utils.module_bl_info 2nd arg `info_basis`.
- addon_utils.modules 1st `module_cache`, 2nd arg `refresh`.
- addon_utils.modules_refresh 1st arg `module_cache`.
- bl_app_template_utils.activate 1nd arg `template_id`.
- bl_app_template_utils.import_from_id 2nd arg `ignore_not_found`.
- bl_app_template_utils.import_from_path 2nd arg `ignore_not_found`.
- bl_keymap_utils.keymap_from_toolbar.generate 2nd & 3rd args `use_fallback_keys` & `use_reset`.
- bl_keymap_utils.platform_helpers.keyconfig_data_oskey_from_ctrl 2nd arg `filter_fn`.
- bl_ui_utils.bug_report_url.url_prefill_from_blender 1st arg `addon_info`.
- bmesh.types.BMFace.copy 1st & 2nd args `verts`, `edges`.
- bmesh.types.BMesh.calc_volume 1st arg `signed`.
- bmesh.types.BMesh.from_mesh 2nd..4th args `face_normals`, `use_shape_key`, `shape_key_index`.
- bmesh.types.BMesh.from_object 3rd & 4th args `cage`, `face_normals`.
- bmesh.types.BMesh.transform 2nd arg `filter`.
- bmesh.types.BMesh.update_edit_mesh 2nd & 3rd args `loop_triangles`, `destructive`.
- bmesh.types.{BMVertSeq,BMEdgeSeq,BMFaceSeq}.sort 1st & 2nd arg `key`, `reverse`.
- bmesh.utils.face_split 4th..6th args `coords`, `use_exist`, `example`.
- bpy.data.libraries.load 2nd..4th args `link`, `relative`, `assets_only`.
- bpy.data.user_map 1st..3rd args `subset`, `key_types, `value_types`.
- bpy.msgbus.subscribe_rna 5th arg `options`.
- bpy.path.abspath 2nd & 3rd args `start` & `library`.
- bpy.path.clean_name 2nd arg `replace`.
- bpy.path.ensure_ext 3rd arg `case_sensitive`.
- bpy.path.module_names 2nd arg `recursive`.
- bpy.path.relpath 2nd arg `start`.
- bpy.types.EditBone.transform 2nd & 3rd arg `scale`, `roll`.
- bpy.types.Operator.as_keywords 1st arg `ignore`.
- bpy.types.Struct.{keyframe_insert,keyframe_delete} 2nd..5th args `index`, `frame`, `group`, `options`.
- bpy.types.WindowManager.popup_menu 2nd & 3rd arg `title`, `icon`.
- bpy.types.WindowManager.popup_menu_pie 3rd & 4th arg `title`, `icon`.
- bpy.utils.app_template_paths 1st arg `subdir`.
- bpy.utils.app_template_paths 1st arg `subdir`.
- bpy.utils.blend_paths 1st..3rd args `absolute`, `packed`, `local`.
- bpy.utils.execfile 2nd arg `mod`.
- bpy.utils.keyconfig_set 2nd arg `report`.
- bpy.utils.load_scripts 1st & 2nd `reload_scripts` & `refresh_scripts`.
- bpy.utils.preset_find 3rd & 4th args `display_name`, `ext`.
- bpy.utils.resource_path 2nd & 3rd arg `major`, `minor`.
- bpy.utils.script_paths 1st..4th args `subdir`, `user_pref`, `check_all`, `use_user`.
- bpy.utils.smpte_from_frame 2nd & 3rd args `fps`, `fps_base`.
- bpy.utils.smpte_from_seconds 2nd & 3rd args `fps`, `fps_base`.
- bpy.utils.system_resource 2nd arg `subdir`.
- bpy.utils.time_from_frame 2nd & 3rd args `fps`, `fps_base`.
- bpy.utils.time_to_frame 2nd & 3rd args `fps`, `fps_base`.
- bpy.utils.units.to_string 4th..6th `precision`, `split_unit`, `compatible_unit`.
- bpy.utils.units.to_value 4th arg `str_ref_unit`.
- bpy.utils.user_resource 2nd & 3rd args `subdir`, `create`
- bpy_extras.view3d_utils.location_3d_to_region_2d 4th arg `default`.
- bpy_extras.view3d_utils.region_2d_to_origin_3d 4th arg `clamp`.
- gpu.offscreen.unbind 1st arg `restore`.
- gpu_extras.batch.batch_for_shader 4th arg `indices`.
- gpu_extras.batch.presets.draw_circle_2d 4th arg `segments`.
- gpu_extras.presets.draw_circle_2d 4th arg `segments`.
- imbuf.types.ImBuf.resize 2nd arg `resize`.
- imbuf.write 2nd arg `filepath`.
- mathutils.kdtree.KDTree.find 2nd arg `filter`.
- nodeitems_utils.NodeCategory 3rd & 4th arg `descriptions`, `items`.
- nodeitems_utils.NodeItem 2nd..4th args `label`, `settings`, `poll`.
- nodeitems_utils.NodeItemCustom 1st & 2nd arg `poll`, `draw`.
- rna_prop_ui.draw 5th arg `use_edit`.
- rna_prop_ui.rna_idprop_ui_get 2nd arg `create`.
- rna_prop_ui.rna_idprop_ui_prop_clear 3rd arg `remove`.
- rna_prop_ui.rna_idprop_ui_prop_get 3rd arg `create`.
- rna_xml.xml2rna 2nd arg `root_rna`.
- rna_xml.xml_file_write 4th arg `skip_typemap`.
2021-06-09 03:05:44 +10:00
72d2355af5
Cleanup: remove redundant cast, use const casts
2021-06-08 00:23:09 +10:00
5e7fb77dc4
BMesh: remove checks for tessellating 2 sided faces
...
2 sided faces aren't supported and will cause problems in many areas
of Blender's code.
Removing (implied) support for faces with fewer than 3 sides
means the total number of triangles is known ahead of time.
This simplifies adding support for multi-threading and partial updates
to an existing tessellation - as the face and loop indices can be used
to access the range of triangles associated with a face.
Also correct outdated comments.
2021-06-01 13:25:00 +10:00
41f2ea4045
Fix incorrect BLI_snprintf usage
...
Event though in practice this wasn't causing problems as the fixed size
buffers are generally large enough not to truncate text.
Using the result from `snprint` or `BLI_snprintf` to step over a fixed
size buffer allows for buffer overruns as the returned value is the size
needed to copy the entire string, not the number of bytes copied.
Building strings using this convention with multiple calls:
ofs += BLI_snprintf(str + ofs, str_len_max - ofs);
.. caused the size argument to become negative,
wrapping it to a large value when cast to the unsigned argument.
2021-05-27 17:59:21 +10:00
8a26fec6ea
Cleanup: use const casts in mathutils API
2021-05-18 14:16:34 +10:00
4dfbaa34c9
PyAPI: allow any vector sequence for poly_3d_calc(..)
...
Previously only vectors were accepted for the second point argument:
mathutils.interpolate.poly_3d_calc()
2021-05-18 14:16:34 +10:00
a86e815dd8
Mathutils: add a Matrix.LocRotScale constructor for combining channels.
...
Combining location, rotation and scale channels into a matrix is
a standard task, so while it is easily accomplished by constructing
and multiplying 3 matrices, having a standard utility allows for
more clear code.
The new constructor builds a 4x4 matrix from separate location,
rotation and scale values. Rotation can be represented as a 3x3
Matrix, Quaternion or Euler value, while the other two inputs
are vectors. Unneeded inputs can be replaced with None.
Differential Revision: https://developer.blender.org/D11264
2021-05-17 19:12:40 +03:00
d5c6485372
Cleanup: clang format
2021-04-01 11:18:26 +11:00
3f47df577d
Cleanup: use new BLI_assert_unreachable macro
2021-03-24 12:38:08 +11:00
1bcc8f8410
Cleanup: Python: naming mismatch in bvh.ray_cast.
2021-02-18 09:09:31 +01:00
dae445d94a
Fix T85573: Building with Python 3.10a5 fails
...
Replace deprecated _PyUnicode_AsString{AndSize} usage.
T83626 still needs to be resolved before 3.10 is usable.
2021-02-13 23:09:55 +11:00
aa43e2ec29
PyAPI: use PyModule_AddType utility function
2021-02-12 08:08:16 +11:00
d21f445469
PyAPI: remove Python 3.7x compatibility code
...
This removes Python version checks needed to build with 3.8+ and 3.7x.
Ref D10381
2021-02-12 08:08:15 +11:00
fd88246d61
Fix error message prefix in Quaternion.to_euler()
...
Fix copy-paste error of error message prefix, so that the Quaternion
function no longer says it's a Matrix function error.
2020-11-19 11:26:54 +01:00
ec6e88d4b2
Cleanup: simplify array usage for Python box packing API
2020-11-18 12:50:44 +11:00
c4d8f6a4a8
Cleanup: clang-format
2020-11-11 09:11:43 +11:00
cd9acfed4f
Cleanup: use preprocessor version check for PyTypeObject declaration
...
While `tp_print` was deprecated, Python 3.8+ uses this for
'tp_vectorcall_offset' which wasn't stated in the comment from
efd71aad4f .
Instead of suppressing clang-tidy, use preprocessor a check since
this properly represents the difference between Python versions.
2020-11-11 09:11:21 +11:00
19a0df25e3
Cleanup: move plane array intersection into a function
...
Also add check to ensure a point isn't occluded by it's own plane,
which could happen if a small epsilon values are passed in.
2020-11-07 21:01:42 +11:00
f11f7ce08e
Cleanup: use ELEM macro (>2 args)
2020-11-06 12:54:19 +11:00
7cb20d841d
Cleanup: follow our code style for float literals
2020-11-06 12:32:54 +11:00
4a78a2774b
Cleanup: use bool argument in BLI_noise
2020-11-06 12:32:54 +11:00
29401f8ca2
Cleanup: BLI_noise
...
Use common prefix as this collided with existing API's (eg BLI_voronoi).
Also expand some non-obvious abbreviations:
- 'g' -> 'generic'
- 'vl' -> 'variable_lacunarity'
- 'V' -> 'v3'
2020-11-06 12:32:54 +11:00
029e1f066e
Cleanup: Add BLI prefix to some BLI_noise functions
2020-11-04 02:07:21 -05:00
c70650785b
Fix out of bounds array access in mathutils.noise
...
Regression in 0b2d1badec .
2020-10-22 14:03:00 +11:00
2abfcebb0e
Cleanup: use C comments for descriptive text
...
Follow our code style guide by using C-comments for text descriptions.
2020-10-10 22:04:51 +11:00
05710171cb
PyDoc: resolve duplicate module warnings
...
Remove submodule listings from the module docstring,
as this information already exists in the generator.
2020-10-09 12:11:00 +11:00
0bae2662f4
Cleanup: Remove/replace C standard library assert() and header usages
...
We have our own assert implementation, `BLI_assert()` that is prefered over the
C standard library one. Its output is more consistent across compilers and
makes termination on assert failure optional (through `WITH_ASSERT_ABORT`).
In many places we'd include the C library header without ever accessing it.
2020-10-03 16:10:15 +02:00
2caa6dd7f8
Cleanup: clang-format
2020-10-01 14:29:45 +02:00
Valentin
5ac4778056
Cleanup: convert gforge task ID's to phabricator format
...
Cleanup old tracker task format to the new. e.g: [#34039 ] to T34039
Ref D8718
2020-09-30 20:11:06 +10:00
7322b83cf2
API docs: Fix sytax error for delaunay_2d_cd
...
Alternative solution to https://developer.blender.org/D8546
2020-09-29 15:50:49 -04:00
4c3047a9cd
API Docs: Use raises field list syntax
...
See
https://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html#info-field-lists
2020-09-29 15:07:41 -04:00