Commit Graph

9217 Commits

Author SHA1 Message Date
7cc4353dff Update knife tool header to reflect that spacebar can be used for confirm too. 2012-04-23 21:04:26 +00:00
b8c4c54ff0 corrected more issues from [#31069] Analyzing the Blender project with PVS-Studio 2012-04-23 16:29:13 +00:00
bfcdd45245 corrections from an article about using PVS-Studio static checker with blender - http://www.viva64.com/en/b/0145/ 2012-04-23 15:54:43 +00:00
9d40c3046b Fix #31072: Making texture single user was modifying textures of original material 2012-04-23 15:51:25 +00:00
f7a59fd1cf rip tool again (this in infact an old bug), when selecting an edge to extend the splitting to, dont step over manifold edges. - would result in duplicate edges. 2012-04-23 15:35:07 +00:00
cccd4b72e5 fix memory leak in rip tool (again own fault). 2012-04-23 15:26:06 +00:00
eff325a98c minor changes to rip internals
- check if vertex ripping has no effect.
- no need to flush selection for vertex rip.
2012-04-23 15:18:12 +00:00
cb91c5d7b2 rip was incorrectly giving an error when ripping a vertex from a face fan (own mistake). 2012-04-23 14:57:47 +00:00
4c873fec53 bmesh py api: functions to add/renmove customdata layers, eg.
bm.loops.layers.color.new("Testing")
2012-04-23 14:52:28 +00:00
aa09c5750e add spacebar to confirm knife cut, space confirms - enter isnt so handy, This is consistent with fly mode and grab. 2012-04-23 11:19:39 +00:00
7eaf3eb58e fix [#30937] Pose UI hack needed to be undone, alternate fix is needed.
rather then assigning the enum, default to the active pose when the property isnt set.
2012-04-23 09:17:37 +00:00
ceffa6e1fa code cleanup: comment unused functions (removed one which isnt useful anymore). 2012-04-23 07:32:13 +00:00
bb17a6b8f8 fix [#31064] Save confirmation stops showing
also comment unused functions.
2012-04-23 06:37:16 +00:00
8baa5fbde2 - fix for python freeing its own bmesh clearing the global mirror cache.
- fix for own mistake (Ctrl+T didnt set beauty peroperty).
- remove bad level includes in bmesh.
2012-04-23 04:24:11 +00:00
b51590d55d code cleanup: bmesh subdivide code - BM_mesh_esubdivideflag() & "esubd" bmesh operator was passing a flag about in a fairly confusing way.
since we will eventually have python bmesh operator access better expose this as multiple booleans.

remove remaining editbutflag's
2012-04-23 03:43:02 +00:00
4c4389f6a4 code cleanup: remove editbutflag flag from toolsettings & related defines. 2012-04-23 02:48:05 +00:00
16ff7e40e6 code cleanup: change C naming convention (so py and C api match), eg:
C: BM_face_calc_area(f), Py: BMFace.calc_area()
2012-04-23 01:19:50 +00:00
5c89138684 style cleanup: comments 2012-04-22 11:54:53 +00:00
3508bf1b83 Ctrl+RMB to select an object in editmode didnt work in edge mode (which is not great usability imho and confusing),
now pass through if no edges can be tagged and select the object.
2012-04-22 05:30:34 +00:00
e57d258169 - fix memory leak in mesh_strip_loose_polysloops(), occurred during 3ds import.
- updating normals in py/api's mesh.transform() wasn't working and gave annoying print, disable this, script authors can call calc_normals explicitly if they need.
2012-04-22 00:27:38 +00:00
b56aabf815 style cleanup: multi-line if statements. 2012-04-21 15:11:03 +00:00
8765dfccf7 style cleanup: correct typos 2012-04-21 14:14:58 +00:00
1c54eaecd8 fix [#31049] New Faces (F) always solid shaded 2012-04-21 13:58:29 +00:00
1615b46963 style cleanup 2012-04-21 13:37:26 +00:00
6701933f5c style cleanup 2012-04-21 12:51:47 +00:00
96b024333e fix [#31047] ctrl+mouse select in edit-mode does not select external object
fix [#30535] Shortest Path Select not working well in vertex mode.

regression from after bmesh merge, Ctrl+Right mouse for selecting shortest path is meant for edge mode only.
2012-04-21 12:14:07 +00:00
f910abadda fix error in recent rip refactor, also add comment. 2012-04-21 06:42:21 +00:00
15eb3452ec style cleanup: pep8, also quiet compiler warning. 2012-04-20 18:50:18 +00:00
b26865ba99 code cleanup: prefer BM_face/edge/vert_select_set() over BM_elem_select_set() when the type is known (saves switch statement check on the type).
Add asserts so the correct types are ensured.
2012-04-20 16:55:47 +00:00
91dc245f93 attempt to fix [#31033], cant redo the bug but button layout wasnt great
- no more blank space under XYZ
- scales with DPI
2012-04-20 16:17:52 +00:00
f627745053 aparently yards are not used a lot, suppress their use in button display (input still knows about them) - was reported as a bug.
also fix minor rip bug where active selection was lost.
2012-04-20 14:59:24 +00:00
cb3dc8ff0e Knife tool: Increase the header string length to avoid clipping the message. 2012-04-20 14:46:46 +00:00
380e6c2a58 refactor rip tool out into vert/edge functions, was getting too unweildy having them mixed in. 2012-04-20 14:36:06 +00:00
ed81982049 knife tool alpha values where being set to zero (intersection points weren't visible), error made when converting to theme colors.
also minor bmesh style cleanup.
2012-04-20 13:45:38 +00:00
5874106ea7 style cleanup 2012-04-20 12:26:16 +00:00
4d1faf1fd9 knife tool: use the knife mouse cursor, dont store the context in the knife tool data, also rename struct camel case (follow own style guide) 2012-04-20 12:19:09 +00:00
aa02acfe95 knife tool: store color once on initializations, de-select only when cutting selected. 2012-04-20 12:05:08 +00:00
617af9d99d knife tool now selects newly cut edges. 2012-04-20 11:14:16 +00:00
3d851bfd5b knife tool modifications
from user freedback it seems there are 2 use cases, both valid.
* Select geometry and cut the selection in half (as 2.4x worked)
* Point-to-point define the faces to cut, dont cut through everything (only cut what you see).

With the second, since you are already selecting the edges to cut and snapping to them. only cutting the selecting is limiting/annoying.


Modifying these options while the knife tool runs doesn't work well, so expose under 2 keys, K, Shift-K.
2012-04-20 10:52:13 +00:00
384f87cd1c rip tool wasnt working on a single edge selection in some cases (own error in recent fix). 2012-04-19 23:16:57 +00:00
741a177a74 bmesh: improve rip tool
- When the rip extends into a fan, pick the opposite edge in the fan (rather then 2 along)
- When stepping over the fan to find the rip edge, walk in the direction closest to the mouse (generally works nicer)
2012-04-19 21:47:32 +00:00
e387ccdb42 bmesh inset: add depth option (make use of relative and even offset options) 2012-04-19 19:03:15 +00:00
c7f8af329b BMESH_TODO: randomize vertices working again.
That whole "element re-arrange" area could use some love, though (e.g. make a single vert operator with more options, as faces; and make faces work in edit mode, probably no more reasons to switch to object mode?). Post-release TODO, anyway.

Also spotted a glitch in BLI_rand code, imho, which makes first element of an array not guarantied to be shuffled by BLI_array_randomize()... No correction though, as this might/would affect other parts of the code!
2012-04-19 18:53:32 +00:00
e730c1af6d committed check by mistake, its not needed. 2012-04-19 17:26:22 +00:00
a82eaf36ca bmesh rip: when there are selected faces call region_to_loop before ripping. gives better results then previous fix when there are selected faces as apart of an edge selection. 2012-04-19 16:57:50 +00:00
bea1a12751 fix [#31015] Rip has weird results in vertex selection mode vs face 2012-04-19 16:20:07 +00:00
b40476455e code cleanup: remove unused BMesh args. 2012-04-19 14:38:09 +00:00
ac6b702c93 Change knife header to reflect current key binding (RMB cancels now). 2012-04-19 13:59:03 +00:00
475ecbb0ce remove BM_ITER, BM_ITER_INDEX macros, use ELEM or MESH variants only (the maceros had unused args in both cases). 2012-04-19 13:47:58 +00:00
9276d7aeb2 For bug #30931, change knife hardcoded colors to ones derived from theme.
For now, just reusing some theme colors that are there for other reasons
but matched approximately the colors used now.
Except that cut lines are now purple-violet, so that they contrast
with grid and edges better, especially in wireframe.
2012-04-19 13:44:28 +00:00