7ba2720a70
Fix T68103: bevel sometimes infinite loops with patch miter.
...
Needed to null terminate list of chain to process width adjustments on.
2019-08-16 13:20:48 -04:00
2790740813
Cleanup: spelling
2019-08-17 00:57:05 +10:00
760dbd1cbf
Cleanup: misc spelling fixes
...
T68035 by @luzpaz
2019-08-01 14:02:41 +10:00
604fdb6e85
Spelling fixes in comments and descriptions, patch by luzpaz
...
Differential Revision: https://developer.blender.org/D3744
2019-07-31 14:27:35 +02:00
9e9c6eac6a
Fix T67595: bevel concave cube corner.
...
The special case test for cube-like corner did not work if normals
are flipped.
2019-07-26 07:41:28 -04:00
4b980e2f57
Fix T67196: bevel bad at a 3-edge bevel.
...
The test for whether or not this was a "pipe" neglected to use
fabsf() around a dot result.
2019-07-20 08:38:41 -04:00
cd6b49f995
Cleanup: spelling
2019-07-07 15:38:41 +10:00
0fd96b4128
Cleanup: spelling
2019-06-15 09:24:38 +10:00
aba4e6810f
Cleanup: style, use braces in source/ (include disabled blocks)
2019-05-31 23:22:52 +10:00
d8dbd49a2f
Cleanup: style, use braces in source/
...
Automated using clang-tidy.
2019-05-31 22:55:15 +10:00
a7ebb4b7d9
Cleanup: clang-format
2019-05-29 00:24:16 +10:00
2e211d099f
Fix T65141 Bevel did not curve.
...
The previous fix to the spike bug T64582 was not really right.
This fixes that one properly and restores the desired curving
profile in the bug's example.
2019-05-28 07:56:56 -04:00
c53f2079b8
Fix T64989 Bevel hangs with Mark Sharp sometimes.
...
Code for extending sharp edges assumes ADJ pattern and this
example uses TRI_FAN pattern. This change doesn't fix TRI_FAN
mark sharp bug at least won't infinite loop any more.
2019-05-26 10:37:58 -04:00
e1d1899e72
Fix T64582: bevel spikes sometimes
...
The code to move the profile plane needed to not do that in
a few more cases.
2019-05-25 09:41:29 -04:00
cbcc2c22d9
Fix Bevel T64107 - width/depth value wrong for vertex only.
...
Code fix from George Vogiatzis (Gvgeo), via D4811.
Needed to initalize vert_axis.
2019-05-07 09:28:34 -04:00
909665a0d4
ClangFormat: run with ReflowComments on source/
...
Prepare for enabling ReflowComments.
2019-05-01 11:13:14 +10:00
3e780507bd
Fix T63759 Vertex Bevel works for width and depth offset types.
...
From D4719 by George Vogiatzis (Gvgeo).
2019-04-30 07:13:22 -04:00
ee192a35e8
Cleanup: comments (long lines) in bmesh
2019-04-29 22:06:26 +10:00
7d6a9b5517
Cleanup: style, use braces
...
Add braces for modules already using braces almost everywhere.
2019-04-22 19:48:17 +10:00
2fb9c8ef12
Cleanup: add missing macros to clang-format
2019-04-21 04:40:16 +10:00
c3a11a5671
Fix T63247: edbm_rip_invoke__edge rips unselected verts on mesh borders
...
Ripping edges would in some cases rip verts on unselected edges. This is now fixed so that we only rip verts from the actually selected edges.
Reviewed By: Brecht
Differential Revision: http://developer.blender.org/D4646
2019-04-17 12:33:33 +02:00
41d4a19865
ClangFormat: format '#if 0' code in source/
2019-04-17 08:24:14 +02:00
e12c08e8d1
ClangFormat: apply to source, most of intern
...
Apply clang format as proposed in T53211.
For details on usage and instructions for migrating branches
without conflicts, see:
https://wiki.blender.org/wiki/Tools/ClangFormat
2019-04-17 06:21:24 +02:00
58233e980e
Cleanup: avoid adjacent C-style comments
...
Causes clang-format to give different results on a second run.
2019-04-16 17:50:17 +02:00
61fa6165df
Fix T63071: Bevel inconsistent results toggling harden_normals.
...
Some iterations in bevel were over a hash table, which leads
to possibly different results run-to-run, especially when
loop_slide is enabled. Changed those iters to go over all verts
of BMesh, which leads to consistent order run-to-run.
2019-04-01 07:58:34 -04:00
8d7005d715
Cleanup: style, use braces for bmesh
2019-03-27 17:14:36 +11:00
23a76491eb
Cleanup: style, use const args where possible
2019-03-23 12:16:38 +11:00
Ish Bosamiya
da5b6ed75b
Modifiers: add minimum number of vertices to triangulate modifier.
...
This lets you only triangulate n-gons when setting the number to 5 or more.
Differential Revision: https://developer.blender.org/D4367
2019-03-22 18:11:14 +01:00
109cbdf2e1
Cleanup: use BLI_kdtree_3d prefix
...
Use prefix now there isn't only the 3d version.
2019-03-20 00:48:51 +11:00
e7fd6c8f30
Cleanup: comment blocks
2019-03-19 15:17:46 +11:00
35b78d9807
Cleanup: indentation, wrapping
...
Mostly functions wrapping args, not confirming to our style guide.
2019-03-15 09:54:30 +11:00
18e5540a48
Cleanup: remove redundant file argument
2019-03-06 11:18:17 +11:00
2b892c6c21
Fix T61988, Bevel miter on small scale.
...
Take two at fix, hopefully without unintended commits
to submodules this time.
2019-02-27 11:52:30 -05:00
4243c29463
Revert "Fix T61988: Bevel mitering on small objects."
...
This reverts commit 048088e1d2
2019-02-27 11:42:48 -05:00
048088e1d2
Fix T61988: Bevel mitering on small objects.
...
When edges had small length (less than about .005) the angle
classification didn't work. Needed some normalization of vectors.
2019-02-27 07:51:57 -05:00
de13d0a80c
doxygen: add newline after \file
...
While \file doesn't need an argument, it can't have another doxy
command after it.
2019-02-18 08:22:12 +11:00
dd97b09fa8
Bevel: fix twist on bevel of cylinder with >= 200 sides.
...
This triggered an "almost parallel" case in setting the
offset meet points, which is OK but code needed improvement
put the meet point in a more accurate place.
This ia fix for part of the report T61214.
2019-02-15 08:32:07 -05:00
5c432cd11b
Fix T61427: Bevel crash with patch miter.
...
The adjustment phase had broken assumptions after adding miters,
and sent a null problem to eigen. Fixed code to check assumptions.
2019-02-14 17:21:50 -05:00
452df3f392
Cleanup: comments
2019-02-12 01:51:03 +11:00
ffd0fee97c
Cleanup: comment indentation & spelling
2019-02-11 10:51:25 +11:00
2f0dbdea4f
Bevel, fix crash when adjust offsets with inner arc miter.
...
Previous assumptions about boundary verts always being attached
to edges are now false.
2019-02-08 09:24:43 -05:00
29922b6ff5
Bevel: fix regression re even adjustment of offsets.
...
Mistakenly had left a debugging assignment that disabled
the offset pass. This commit re-enables it.
2019-02-08 09:02:29 -05:00
dec4f6d7ed
Bevel: better attachment points for unbeveled edges, arc miter.
2019-02-07 10:42:28 -05:00
eef4077f18
Cleanup: remove redundant doxygen \file argument
...
Move \ingroup onto same line to be more compact and
make it clear the file is in the group.
2019-02-06 15:45:22 +11:00
65ec7ec524
Cleanup: remove redundant, invalid info from headers
...
BF-admins agree to remove header information that isn't useful,
to reduce noise.
- BEGIN/END license blocks
Developers should add non license comments as separate comment blocks.
No need for separator text.
- Contributors
This is often invalid, outdated or misleading
especially when splitting files.
It's more useful to git-blame to find out who has developed the code.
See P901 for script to perform these edits.
2019-02-02 01:36:28 +11:00
293f4d88da
Cleanup: style, unused variable
2019-01-31 15:54:37 +11:00
79f76c8544
Bevel - better corner shapes for inner arc miters.
...
The subdivision method for getting corner shapes has a fullness
parameter which had been set by eye before. This change uses fullness
as found by offline search process to best match the superellipsoid
octant in the cube corner case (except cube corner case is still handled
by other code). This somewhat improves the look of cube corners with
inner arc miters, however.
2019-01-29 07:21:59 -05:00
1e4aab36c2
Cleanup: remove redundant BKE/BLI/BIF headers
2019-01-26 21:20:25 +11:00
49208a3419
Cleanup: shadow warning, style
2019-01-21 10:05:58 +11:00
b640fd829e
Add miter pattern options.
...
Will document the new options in release notes, then in manual.
Still a bit of work to do on the bulging shape that appears
on cube corners if using arc inner miters, but will do that later.
Also need to do something smarter in clamp overlap.
2019-01-18 12:54:10 -05:00
