Commit Graph

46 Commits

Author SHA1 Message Date
75198e98bb fix for error in filled rip copying customdata (new triangles were flipped across the edges of the empty space they spanned) only noticeable when the customdata on either size of the rip didnt match. 2012-10-15 03:36:22 +00:00
8ebe1e4afe code cleanup: remove redundant pointer indirection. 2012-10-15 03:27:05 +00:00
b7f4c69ef7 More UI messages and BKE_reportf->BKE_report fixes... 2012-10-14 15:29:09 +00:00
643f331cb5 Rip-fill mesh tool (option for rip operator)
Alt+V will fill the area inbetween the ripped faces - a bit like extrude.
faces are flipped to match existing geometry and customdata (uv, vcols etc) is copied from surrounding geometry too.
2012-10-14 04:42:11 +00:00
29ab21ee95 fix for own error, leaving in test code to set the smooth flag. 2012-10-13 10:41:34 +00:00
f81b06cfa5 improve edge rip when the edge has only 2 other connected edges.
common case ripping an edge of the default cube, it didn't run the edge size check.
2012-10-13 03:59:06 +00:00
da155c2dcb style cleanup: spelling 2012-10-13 03:54:27 +00:00
7412e321a3 add support for ripping off a single face from a single vertex when the vertex has 3 surrounding verts & faces. 2012-10-13 01:46:57 +00:00
8b7896814f code cleanup: reduce change the size of some float vectors that were bigger then they needed to be.
update to clang_array_check.py - parse function definitions lazily for some speedup.
2012-10-08 07:08:29 +00:00
4cc29110aa fix writing past array bounds in imagewraposa().
also correct array sizes in othere areas.
2012-10-06 12:04:09 +00:00
edb78d090c code cleanup:
- make view3d project names more consistent.
- remove apply_project_float() its not needed.
- update comments referencing an old function name.
- move doxygen docs into the C file, prefer they are kept here to avoid getting out of sync with code.
2012-09-20 04:56:24 +00:00
a9f10b6bc2 style cleanup 2012-09-08 06:40:03 +00:00
d5bcec80c8 minor fix for previous commit. ripping a vert-edge connected to a face would always choose the face even if the mouse is closer to the edge, now check both edges and faces when ripping from a non wire vertex 2012-09-07 06:46:26 +00:00
cdc9e553c1 minor improvements to rip
- rip tool didnt select the best edge to rip for wire verts (no connected faces)
- ripping one vert with 2 edges connected didnt work.
2012-09-07 06:31:54 +00:00
f2074949e7 code cleanup: reduce calling sqrt() when distances are only calculated for comparison use dist_squared_to_line_segment_v2(). 2012-08-14 08:44:35 +00:00
69a7e0af02 rename bmesh ops since they are exposed in an api now. 2012-06-30 15:27:13 +00:00
3896ad4cbb code cleanup: spelling 2012-05-20 21:23:26 +00:00
2d2d36fe3b code cleanup:
- style - multi-line ifs move braces onto new lines.
- iterators - convert some to macros, other split up and move brace.
2012-05-20 19:49:27 +00:00
e2c453b5f9 style cleanup: editors / mesh & object 2012-04-28 15:42:27 +00:00
ef054e165c style cleanup: format 'for' loop macros the same as for loops, some renaming to BLI_array macros. 2012-04-28 15:14:16 +00:00
950ed69297 code cleanup:
- replace inline face UV center calc.
- use const float[3] for mesh and uv functions.
- remove unused define
2012-04-28 08:29:20 +00:00
47b6b60e5a code cleanup: no functional change - had both EDBM_editselection_* and BM_editselection_* funcs, replace EDBM_ funcs. 2012-04-24 21:19:18 +00:00
f7a59fd1cf rip tool again (this in infact an old bug), when selecting an edge to extend the splitting to, dont step over manifold edges. - would result in duplicate edges. 2012-04-23 15:35:07 +00:00
cccd4b72e5 fix memory leak in rip tool (again own fault). 2012-04-23 15:26:06 +00:00
eff325a98c minor changes to rip internals
- check if vertex ripping has no effect.
- no need to flush selection for vertex rip.
2012-04-23 15:18:12 +00:00
cb91c5d7b2 rip was incorrectly giving an error when ripping a vertex from a face fan (own mistake). 2012-04-23 14:57:47 +00:00
16ff7e40e6 code cleanup: change C naming convention (so py and C api match), eg:
C: BM_face_calc_area(f), Py: BMFace.calc_area()
2012-04-23 01:19:50 +00:00
8765dfccf7 style cleanup: correct typos 2012-04-21 14:14:58 +00:00
96b024333e fix [#31047] ctrl+mouse select in edit-mode does not select external object
fix [#30535] Shortest Path Select not working well in vertex mode.

regression from after bmesh merge, Ctrl+Right mouse for selecting shortest path is meant for edge mode only.
2012-04-21 12:14:07 +00:00
f910abadda fix error in recent rip refactor, also add comment. 2012-04-21 06:42:21 +00:00
15eb3452ec style cleanup: pep8, also quiet compiler warning. 2012-04-20 18:50:18 +00:00
b26865ba99 code cleanup: prefer BM_face/edge/vert_select_set() over BM_elem_select_set() when the type is known (saves switch statement check on the type).
Add asserts so the correct types are ensured.
2012-04-20 16:55:47 +00:00
f627745053 aparently yards are not used a lot, suppress their use in button display (input still knows about them) - was reported as a bug.
also fix minor rip bug where active selection was lost.
2012-04-20 14:59:24 +00:00
380e6c2a58 refactor rip tool out into vert/edge functions, was getting too unweildy having them mixed in. 2012-04-20 14:36:06 +00:00
384f87cd1c rip tool wasnt working on a single edge selection in some cases (own error in recent fix). 2012-04-19 23:16:57 +00:00
741a177a74 bmesh: improve rip tool
- When the rip extends into a fan, pick the opposite edge in the fan (rather then 2 along)
- When stepping over the fan to find the rip edge, walk in the direction closest to the mouse (generally works nicer)
2012-04-19 21:47:32 +00:00
e730c1af6d committed check by mistake, its not needed. 2012-04-19 17:26:22 +00:00
a82eaf36ca bmesh rip: when there are selected faces call region_to_loop before ripping. gives better results then previous fix when there are selected faces as apart of an edge selection. 2012-04-19 16:57:50 +00:00
bea1a12751 fix [#31015] Rip has weird results in vertex selection mode vs face 2012-04-19 16:20:07 +00:00
b40476455e code cleanup: remove unused BMesh args. 2012-04-19 14:38:09 +00:00
475ecbb0ce remove BM_ITER, BM_ITER_INDEX macros, use ELEM or MESH variants only (the maceros had unused args in both cases). 2012-04-19 13:47:58 +00:00
75b869e428 style cleanup: BM_ITER / BM_ITER_INDEX / BMO_ITER 2012-04-19 11:44:12 +00:00
f1ececaabb code cleanup: replace use of BM_edge_face_count with BM_edge_is_manifold and BM_edge_is_boundary 2012-04-18 06:44:48 +00:00
830013aabe fix error in single vertex ripping where the edit-selection could be left on unselected verts or not set on the newly ripped vertex.
also some corrections to comments.
2012-04-17 18:36:29 +00:00
1d6a5a4aa4 fix [#30970] Rip Tool: selecting the side of edges works incorrectly 2012-04-17 18:14:31 +00:00
09f722740f move rip out into its own file 2012-04-17 10:25:23 +00:00