This repository has been archived on 2023-10-09. You can view files and clone it. You cannot open issues or pull requests or push a commit.
Files
blender-archive/source/blender/blenkernel/intern/volume_to_mesh.cc
Hans Goudey 16fbadde36 Mesh: Replace MLoop struct with generic attributes
Implements #102359.

Split the `MLoop` struct into two separate integer arrays called
`corner_verts` and `corner_edges`, referring to the vertex each corner
is attached to and the next edge around the face at each corner. These
arrays can be sliced to give access to the edges or vertices in a face.
Then they are often referred to as "poly_verts" or "poly_edges".

The main benefits are halving the necessary memory bandwidth when only
one array is used and simplifications from using regular integer indices
instead of a special-purpose struct.

The commit also starts a renaming from "loop" to "corner" in mesh code.

Like the other mesh struct of array refactors, forward compatibility is
kept by writing files with the older format. This will be done until 4.0
to ease the transition process.

Looking at a small portion of the patch should give a good impression
for the rest of the changes. I tried to make the changes as small as
possible so it's easy to tell the correctness from the diff. Though I
found Blender developers have been very inventive over the last decade
when finding different ways to loop over the corners in a face.

For performance, nearly every piece of code that deals with `Mesh` is
slightly impacted. Any algorithm that is memory bottle-necked should
see an improvement. For example, here is a comparison of interpolating
a vertex float attribute to face corners (Ryzen 3700x):

**Before** (Average: 3.7 ms, Min: 3.4 ms)
```
threading::parallel_for(loops.index_range(), 4096, [&](IndexRange range) {
  for (const int64_t i : range) {
    dst[i] = src[loops[i].v];
  }
});
```

**After** (Average: 2.9 ms, Min: 2.6 ms)
```
array_utils::gather(src, corner_verts, dst);
```

That's an improvement of 28% to the average timings, and it's also a
simplification, since an index-based routine can be used instead.
For more examples using the new arrays, see the design task.

Pull Request: blender/blender#104424
2023-03-20 15:55:13 +01:00

191 lines
6.6 KiB
C++

/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <vector>
#include "BLI_math_vector_types.hh"
#include "BLI_span.hh"
#include "BLI_utildefines.h"
#include "DNA_mesh_types.h"
#include "DNA_meshdata_types.h"
#include "DNA_volume_types.h"
#include "BKE_mesh.hh"
#include "BKE_volume.h"
#ifdef WITH_OPENVDB
# include <openvdb/tools/GridTransformer.h>
# include <openvdb/tools/VolumeToMesh.h>
#endif
#include "BKE_volume_to_mesh.hh"
namespace blender::bke {
#ifdef WITH_OPENVDB
struct VolumeToMeshOp {
const openvdb::GridBase &base_grid;
const VolumeToMeshResolution resolution;
const float threshold;
const float adaptivity;
std::vector<openvdb::Vec3s> verts;
std::vector<openvdb::Vec3I> tris;
std::vector<openvdb::Vec4I> quads;
template<typename GridType> bool operator()()
{
if constexpr (std::is_scalar_v<typename GridType::ValueType>) {
this->generate_mesh_data<GridType>();
return true;
}
return false;
}
template<typename GridType> void generate_mesh_data()
{
const GridType &grid = static_cast<const GridType &>(base_grid);
if (this->resolution.mode == VOLUME_TO_MESH_RESOLUTION_MODE_GRID) {
this->grid_to_mesh(grid);
return;
}
const float resolution_factor = this->compute_resolution_factor(base_grid);
typename GridType::Ptr temp_grid = this->create_grid_with_changed_resolution(
grid, resolution_factor);
this->grid_to_mesh(*temp_grid);
}
template<typename GridType>
typename GridType::Ptr create_grid_with_changed_resolution(const GridType &old_grid,
const float resolution_factor)
{
BLI_assert(resolution_factor > 0.0f);
openvdb::Mat4R xform;
xform.setToScale(openvdb::Vec3d(resolution_factor));
openvdb::tools::GridTransformer transformer{xform};
typename GridType::Ptr new_grid = GridType::create();
transformer.transformGrid<openvdb::tools::BoxSampler>(old_grid, *new_grid);
new_grid->transform() = old_grid.transform();
new_grid->transform().preScale(1.0f / resolution_factor);
return new_grid;
}
float compute_resolution_factor(const openvdb::GridBase &grid) const
{
const openvdb::Vec3s voxel_size{grid.voxelSize()};
const float current_voxel_size = std::max({voxel_size[0], voxel_size[1], voxel_size[2]});
const float desired_voxel_size = this->compute_desired_voxel_size(grid);
return current_voxel_size / desired_voxel_size;
}
float compute_desired_voxel_size(const openvdb::GridBase &grid) const
{
if (this->resolution.mode == VOLUME_TO_MESH_RESOLUTION_MODE_VOXEL_SIZE) {
return this->resolution.settings.voxel_size;
}
const openvdb::CoordBBox coord_bbox = base_grid.evalActiveVoxelBoundingBox();
const openvdb::BBoxd bbox = grid.transform().indexToWorld(coord_bbox);
const float max_extent = bbox.extents()[bbox.maxExtent()];
const float voxel_size = max_extent / this->resolution.settings.voxel_amount;
return voxel_size;
}
template<typename GridType> void grid_to_mesh(const GridType &grid)
{
openvdb::tools::volumeToMesh(
grid, this->verts, this->tris, this->quads, this->threshold, this->adaptivity);
/* Better align generated mesh with volume (see #85312). */
openvdb::Vec3s offset = grid.voxelSize() / 2.0f;
for (openvdb::Vec3s &position : this->verts) {
position += offset;
}
}
};
void fill_mesh_from_openvdb_data(const Span<openvdb::Vec3s> vdb_verts,
const Span<openvdb::Vec3I> vdb_tris,
const Span<openvdb::Vec4I> vdb_quads,
const int vert_offset,
const int poly_offset,
const int loop_offset,
MutableSpan<float3> vert_positions,
MutableSpan<MPoly> polys,
MutableSpan<int> corner_verts)
{
/* Write vertices. */
vert_positions.slice(vert_offset, vdb_verts.size()).copy_from(vdb_verts.cast<float3>());
/* Write triangles. */
for (const int i : vdb_tris.index_range()) {
polys[poly_offset + i].loopstart = loop_offset + 3 * i;
polys[poly_offset + i].totloop = 3;
for (int j = 0; j < 3; j++) {
/* Reverse vertex order to get correct normals. */
corner_verts[loop_offset + 3 * i + j] = vert_offset + vdb_tris[i][2 - j];
}
}
/* Write quads. */
const int quad_offset = poly_offset + vdb_tris.size();
const int quad_loop_offset = loop_offset + vdb_tris.size() * 3;
for (const int i : vdb_quads.index_range()) {
polys[quad_offset + i].loopstart = quad_loop_offset + 4 * i;
polys[quad_offset + i].totloop = 4;
for (int j = 0; j < 4; j++) {
/* Reverse vertex order to get correct normals. */
corner_verts[quad_loop_offset + 4 * i + j] = vert_offset + vdb_quads[i][3 - j];
}
}
}
bke::OpenVDBMeshData volume_to_mesh_data(const openvdb::GridBase &grid,
const VolumeToMeshResolution &resolution,
const float threshold,
const float adaptivity)
{
const VolumeGridType grid_type = BKE_volume_grid_type_openvdb(grid);
VolumeToMeshOp to_mesh_op{grid, resolution, threshold, adaptivity};
if (!BKE_volume_grid_type_operation(grid_type, to_mesh_op)) {
return {};
}
return {std::move(to_mesh_op.verts), std::move(to_mesh_op.tris), std::move(to_mesh_op.quads)};
}
Mesh *volume_to_mesh(const openvdb::GridBase &grid,
const VolumeToMeshResolution &resolution,
const float threshold,
const float adaptivity)
{
const bke::OpenVDBMeshData mesh_data = volume_to_mesh_data(
grid, resolution, threshold, adaptivity);
const int tot_loops = 3 * mesh_data.tris.size() + 4 * mesh_data.quads.size();
const int tot_polys = mesh_data.tris.size() + mesh_data.quads.size();
Mesh *mesh = BKE_mesh_new_nomain(mesh_data.verts.size(), 0, tot_loops, tot_polys);
fill_mesh_from_openvdb_data(mesh_data.verts,
mesh_data.tris,
mesh_data.quads,
0,
0,
0,
mesh->vert_positions_for_write(),
mesh->polys_for_write(),
mesh->corner_verts_for_write());
BKE_mesh_calc_edges(mesh, false, false);
BKE_mesh_smooth_flag_set(mesh, false);
return mesh;
}
#endif /* WITH_OPENVDB */
} // namespace blender::bke