Jeroen Bakker
f828ecf4ba
The GPU module has 2 different styles when reading back data from GPU buffers. The SSBOs used a memcpy to copy the data to a pre-allocated buffer. IndexBuf/VertBuf gave back a driver/platform controlled pointer to the memory. Readback is done for test cases returning mapped pointers is not safe. For this reason we settled on using the same approach as the SSBO. Copy the data to a caller pre-allocated buffer. Reason why this API is currently changed is that the Vulkan API is more strict on mapping/unmapping buffers that can lead to potential issues down the road. Pull Request #104571
78 lines
1.6 KiB
C++
78 lines
1.6 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later
|
|
* Copyright 2020 Blender Foundation. All rights reserved. */
|
|
|
|
/** \file
|
|
* \ingroup gpu
|
|
*/
|
|
|
|
#include "gl_context.hh"
|
|
|
|
#include "gl_index_buffer.hh"
|
|
|
|
namespace blender::gpu {
|
|
|
|
GLIndexBuf::~GLIndexBuf()
|
|
{
|
|
GLContext::buf_free(ibo_id_);
|
|
}
|
|
|
|
void GLIndexBuf::bind()
|
|
{
|
|
if (is_subrange_) {
|
|
static_cast<GLIndexBuf *>(src_)->bind();
|
|
return;
|
|
}
|
|
|
|
const bool allocate_on_device = ibo_id_ == 0;
|
|
if (allocate_on_device) {
|
|
glGenBuffers(1, &ibo_id_);
|
|
}
|
|
|
|
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, ibo_id_);
|
|
|
|
if (data_ != nullptr || allocate_on_device) {
|
|
size_t size = this->size_get();
|
|
/* Sends data to GPU. */
|
|
glBufferData(GL_ELEMENT_ARRAY_BUFFER, size, data_, GL_STATIC_DRAW);
|
|
/* No need to keep copy of data in system memory. */
|
|
MEM_SAFE_FREE(data_);
|
|
}
|
|
}
|
|
|
|
void GLIndexBuf::bind_as_ssbo(uint binding)
|
|
{
|
|
bind();
|
|
BLI_assert(ibo_id_ != 0);
|
|
glBindBufferBase(GL_SHADER_STORAGE_BUFFER, binding, ibo_id_);
|
|
}
|
|
|
|
void GLIndexBuf::read(uint32_t *data) const
|
|
{
|
|
BLI_assert(is_active());
|
|
void *buffer = glMapBuffer(GL_ELEMENT_ARRAY_BUFFER, GL_READ_ONLY);
|
|
memcpy(data, buffer, size_get());
|
|
glUnmapBuffer(GL_ELEMENT_ARRAY_BUFFER);
|
|
}
|
|
|
|
bool GLIndexBuf::is_active() const
|
|
{
|
|
if (!ibo_id_) {
|
|
return false;
|
|
}
|
|
int active_ibo_id = 0;
|
|
glGetIntegerv(GL_ELEMENT_ARRAY_BUFFER_BINDING, &active_ibo_id);
|
|
return ibo_id_ == active_ibo_id;
|
|
}
|
|
|
|
void GLIndexBuf::upload_data()
|
|
{
|
|
bind();
|
|
}
|
|
|
|
void GLIndexBuf::update_sub(uint start, uint len, const void *data)
|
|
{
|
|
glBufferSubData(GL_ELEMENT_ARRAY_BUFFER, start, len, data);
|
|
}
|
|
|
|
} // namespace blender::gpu
|