Sybren A. Stüvel
1c5722ba07
When using `asset_mark` function from a Python script and afterwards updating the preview image, a crash might happen. The preview image is generated by the `asset_mark` function. This may happen on a background thread, introducing potential synchronization issues. This patch fixes this by separating the preview generation `ID.asset_generate_preview` from the mark as asset `ID.asset_mark`. Note: this separation of "mark as asset" and "generate preview" also applies to the `ED_asset_mark_id()` C function; if it is desired to have previews rendered after marking as asset, a call to `ED_asset_generate_preview()` is now also required. Reviewed By: sybren Maniphest Tasks: T91197 Differential Revision: https://developer.blender.org/D12922
60 lines
1.8 KiB
C++
60 lines
1.8 KiB
C++
/*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
*/
|
|
|
|
/** \file
|
|
* \ingroup edasset
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif
|
|
|
|
struct ID;
|
|
struct bContext;
|
|
|
|
/**
|
|
* Mark the datablock as asset.
|
|
*
|
|
* To ensure the datablock is saved, this sets Fake User.
|
|
*
|
|
* \return whether the datablock was marked as asset; false when it is not capable of becoming an
|
|
* asset, or when it already was an asset. */
|
|
bool ED_asset_mark_id(struct ID *id);
|
|
|
|
/**
|
|
* Generate preview image for the given datablock.
|
|
*
|
|
* The preview image might be generated using a background thread.
|
|
*/
|
|
void ED_asset_generate_preview(const struct bContext *C, struct ID *id);
|
|
|
|
/**
|
|
* Remove the asset metadata, turning the ID into a "normal" ID.
|
|
*
|
|
* This clears the Fake User. If for some reason the datablock is meant to be saved anyway, the
|
|
* caller is responsible for explicitly setting the Fake User.
|
|
*
|
|
* \return whether the asset metadata was actually removed; false when the ID was not an asset. */
|
|
bool ED_asset_clear_id(struct ID *id);
|
|
|
|
bool ED_asset_can_mark_single_from_context(const struct bContext *C);
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif
|