This repository has been archived on 2023-10-09. You can view files and clone it. You cannot open issues or pull requests or push a commit.
Files
blender-archive/source/blender/windowmanager/intern/wm_operator_utils.c
Germano Cavalcante 1d1855e95f Allow navigating while transforming
This feature has been desired for some time:
- https://rightclickselect.com/p/ui/Tqbbbc/allow-navigating-while-transforming (See comments);
- D1583;
- T37427;

In short, blocking navigation during transform limits the user to move the object only to visible areas within the screen and hinders the allocation of objects within closed meshes.

The node editor is also impaired because some nodes are far between them and the connectors are too small.

The only disadvantage of this patch (as I see it) is the conflict with the existing key map:
MIDDLEMOUSE:
- enable axis constrain in 3D view;

WHEELDOWNMOUSE, WHEELUPMOUSE, PAGEUPKEY, PAGEDOWNKEY:
- change the threshold of the proportional edit;

So the patch solution was to change these keymaps:
- MIDDLEMOUSE to Alt+MIDDLEMOUSE;
- WHEELDOWNMOUSE, WHEELUPMOUSE, PAGEUPKEY, PAGEDOWNKEY to Alt+(corresponding key);

When you use this new keymap for the first time in the proportional edit, it may seem strange due to the custom of using it (both in View2D and View3D).
But quickly the user gets used to it.

Alternatively we can add an option to the user preferences ([] Allow navigating while transforming). (I'm not much fan of this option).

The patch was done on branch2.8. But maybe it's a good idea to apply it to 2.79

Differential Revision: https://developer.blender.org/D2624
2021-11-18 13:14:18 -03:00

463 lines
13 KiB
C

/*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
/** \file
* \ingroup wm
*
* Utilities for Implementing Operators
*/
#include <math.h>
#include <string.h>
#include "BLI_listbase.h"
#include "BLI_string.h"
#include "BLI_utildefines.h"
#include "BKE_context.h"
#include "BKE_global.h"
#include "BKE_layer.h"
#include "RNA_access.h"
#include "RNA_define.h"
#include "WM_api.h" /* Own include. */
#include "WM_types.h"
#include "wm_event_system.h"
#include "MEM_guardedalloc.h"
#include "ED_object.h"
#include "ED_screen.h"
/* -------------------------------------------------------------------- */
/** \name Generic Utilities
* \{ */
/**
* Only finish + pass through for press events (allowing press-tweak).
*/
int WM_operator_flag_only_pass_through_on_press(int retval, const struct wmEvent *event)
{
if ((event->val != KM_PRESS) &&
((retval & OPERATOR_PASS_THROUGH) && (retval & OPERATOR_FINISHED))) {
retval &= ~OPERATOR_PASS_THROUGH;
}
return retval;
}
/** \} */
/* -------------------------------------------------------------------- */
/** \name Value Interaction Helper
*
* Possible additions (add as needed).
* - Int support.
* - Configurable motion (x/y).
*
* \{ */
typedef struct ValueInteraction {
struct {
float mval[2];
float prop_value;
} init;
struct {
float prop_value;
bool is_snap;
bool is_precise;
} prev;
float range[2];
struct {
ScrArea *area;
ARegion *region;
} context_vars;
} ValueInteraction;
static void interactive_value_init(bContext *C,
ValueInteraction *inter,
const wmEvent *event,
const float value_final,
const float range[2])
{
inter->context_vars.area = CTX_wm_area(C);
inter->context_vars.region = CTX_wm_region(C);
inter->init.mval[0] = event->mval[0];
inter->init.mval[1] = event->mval[1];
inter->init.prop_value = value_final;
inter->prev.prop_value = value_final;
inter->range[0] = range[0];
inter->range[1] = range[1];
}
static void interactive_value_init_from_property(
bContext *C, ValueInteraction *inter, const wmEvent *event, PointerRNA *ptr, PropertyRNA *prop)
{
float range[2];
float step, precision;
RNA_property_float_ui_range(ptr, prop, &range[0], &range[1], &step, &precision);
const float value_final = RNA_property_float_get(ptr, prop);
interactive_value_init(C, inter, event, value_final, range);
}
static void interactive_value_exit(ValueInteraction *inter)
{
ED_area_status_text(inter->context_vars.area, NULL);
}
static bool interactive_value_update(ValueInteraction *inter,
const wmEvent *event,
float *r_value_final)
{
const int mval_axis = 0;
const float value_scale = 4.0f; /* Could be option. */
const float value_range = inter->range[1] - inter->range[0];
const int mval_curr = event->mval[mval_axis];
const int mval_init = inter->init.mval[mval_axis];
float value_delta = (inter->init.prop_value +
(((float)(mval_curr - mval_init) / inter->context_vars.region->winx) *
value_range)) *
value_scale;
if (event->ctrl) {
const double snap = 0.1;
value_delta = (float)roundf((double)value_delta / snap) * snap;
}
if (event->shift) {
value_delta *= 0.1f;
}
const float value_final = inter->init.prop_value + value_delta;
const bool changed = value_final != inter->prev.prop_value;
if (changed) {
/* set the property for the operator and call its modal function */
char str[64];
SNPRINTF(str, "%.4f", value_final);
ED_area_status_text(inter->context_vars.area, str);
}
inter->prev.prop_value = value_final;
inter->prev.is_snap = event->ctrl;
inter->prev.is_precise = event->shift;
*r_value_final = value_final;
return changed;
}
/** \} */
/* -------------------------------------------------------------------- */
/** \name Object Edit Mode Coords (Modal Callbacks)
*
* \note We could support object mode coords too, it's just not needed at the moment.
* \{ */
struct ObCustomData_ForEditMode {
int launch_event;
bool wait_for_input;
bool is_active;
bool is_first;
ValueInteraction inter;
/** This could be split into a sub-type if we support different kinds of data. */
Object **objects;
uint objects_len;
struct XFormObjectData **objects_xform;
};
/* Internal callback to free. */
static void op_generic_value_exit(wmOperator *op)
{
struct ObCustomData_ForEditMode *cd = op->customdata;
if (cd) {
interactive_value_exit(&cd->inter);
for (uint ob_index = 0; ob_index < cd->objects_len; ob_index++) {
struct XFormObjectData *xod = cd->objects_xform[ob_index];
if (xod != NULL) {
ED_object_data_xform_destroy(xod);
}
}
MEM_freeN(cd->objects);
MEM_freeN(cd->objects_xform);
MEM_freeN(cd);
}
G.moving &= ~G_TRANSFORM_EDIT;
}
static void op_generic_value_restore(wmOperator *op)
{
struct ObCustomData_ForEditMode *cd = op->customdata;
for (uint ob_index = 0; ob_index < cd->objects_len; ob_index++) {
ED_object_data_xform_restore(cd->objects_xform[ob_index]);
ED_object_data_xform_tag_update(cd->objects_xform[ob_index]);
}
}
static void op_generic_value_cancel(bContext *UNUSED(C), wmOperator *op)
{
op_generic_value_exit(op);
}
static int op_generic_value_invoke(bContext *C, wmOperator *op, const wmEvent *event)
{
if (RNA_property_is_set(op->ptr, op->type->prop)) {
return WM_operator_call_notest(C, op);
}
ViewLayer *view_layer = CTX_data_view_layer(C);
uint objects_len;
Object **objects = BKE_view_layer_array_from_objects_in_edit_mode_unique_data(
view_layer, CTX_wm_view3d(C), &objects_len);
if (objects_len == 0) {
MEM_freeN(objects);
return OPERATOR_CANCELLED;
}
struct ObCustomData_ForEditMode *cd = MEM_callocN(sizeof(*cd), __func__);
cd->launch_event = WM_userdef_event_type_from_keymap_type(event->type);
cd->wait_for_input = RNA_boolean_get(op->ptr, "wait_for_input");
cd->is_active = !cd->wait_for_input;
cd->is_first = true;
cd->objects = objects;
cd->objects_len = objects_len;
if (cd->wait_for_input == false) {
interactive_value_init_from_property(C, &cd->inter, event, op->ptr, op->type->prop);
}
cd->objects_xform = MEM_callocN(sizeof(*cd->objects_xform) * objects_len, __func__);
for (uint ob_index = 0; ob_index < objects_len; ob_index++) {
Object *obedit = objects[ob_index];
cd->objects_xform[ob_index] = ED_object_data_xform_create_from_edit_mode(obedit->data);
}
op->customdata = cd;
WM_event_add_modal_handler(C, op);
G.moving |= G_TRANSFORM_EDIT;
return OPERATOR_RUNNING_MODAL;
}
static int op_generic_value_modal(bContext *C, wmOperator *op, const wmEvent *event)
{
struct ObCustomData_ForEditMode *cd = op->customdata;
/* Special case, check if we release the event that activated this operator. */
if ((event->type == cd->launch_event) && (event->val == KM_RELEASE)) {
if (cd->wait_for_input == false) {
op_generic_value_exit(op);
return OPERATOR_FINISHED;
}
}
switch (event->type) {
case MOUSEMOVE:
case EVT_LEFTCTRLKEY:
case EVT_RIGHTCTRLKEY:
case EVT_LEFTSHIFTKEY:
case EVT_RIGHTSHIFTKEY: {
float value_final;
if (cd->is_active && interactive_value_update(&cd->inter, event, &value_final)) {
wmWindowManager *wm = CTX_wm_manager(C);
RNA_property_float_set(op->ptr, op->type->prop, value_final);
if (cd->is_first == false) {
op_generic_value_restore(op);
}
wm->op_undo_depth++;
int retval = op->type->exec(C, op);
OPERATOR_RETVAL_CHECK(retval);
wm->op_undo_depth--;
cd->is_first = false;
if ((retval & OPERATOR_FINISHED) == 0) {
op_generic_value_exit(op);
return OPERATOR_CANCELLED;
}
}
break;
}
case EVT_RETKEY:
case EVT_PADENTER:
case LEFTMOUSE: {
if (cd->wait_for_input) {
if (event->val == KM_PRESS) {
if (cd->is_active == false) {
cd->is_active = true;
interactive_value_init_from_property(C, &cd->inter, event, op->ptr, op->type->prop);
}
}
else if (event->val == KM_RELEASE) {
if (cd->is_active == true) {
op_generic_value_exit(op);
return OPERATOR_FINISHED;
}
}
}
else {
if (event->val == KM_RELEASE) {
op_generic_value_exit(op);
return OPERATOR_FINISHED;
}
}
break;
}
case EVT_ESCKEY:
case RIGHTMOUSE: {
if (event->val == KM_PRESS) {
if (cd->is_active == true) {
op_generic_value_restore(op);
}
op_generic_value_exit(op);
return OPERATOR_CANCELLED;
}
break;
}
}
return OPERATOR_RUNNING_MODAL;
}
/**
* Allow an operator with only and execute function to run modally,
* re-doing the action, using vertex coordinate store/restore instead of operator undo.
*/
void WM_operator_type_modal_from_exec_for_object_edit_coords(wmOperatorType *ot)
{
PropertyRNA *prop;
BLI_assert(ot->modal == NULL);
BLI_assert(ot->invoke == NULL);
BLI_assert(ot->cancel == NULL);
BLI_assert(ot->prop != NULL);
ot->invoke = op_generic_value_invoke;
ot->modal = op_generic_value_modal;
ot->cancel = op_generic_value_cancel;
prop = RNA_def_boolean(ot->srna, "wait_for_input", true, "Wait for Input", "");
RNA_def_property_flag(prop, PROP_HIDDEN | PROP_SKIP_SAVE);
}
bool WM_operator_do_navigation(bContext *C, wmOperator *op, const wmEvent *event)
{
const char *op_names[] = {
/* 3D View. */
"VIEW3D_OT_zoom",
"VIEW3D_OT_rotate",
"VIEW3D_OT_move",
"VIEW3D_OT_view_pan",
"VIEW3D_OT_dolly",
"VIEW3D_OT_view_orbit",
"VIEW3D_OT_view_roll",
#ifdef WITH_INPUT_NDOF
"VIEW3D_OT_ndof_orbit_zoom",
"VIEW3D_OT_ndof_orbit",
"VIEW3D_OT_ndof_pan",
"VIEW3D_OT_ndof_all",
#endif
/* Image. */
"IMAGE_OT_view_pan",
"IMAGE_OT_view_zoom_in",
"IMAGE_OT_view_zoom_out",
#ifdef WITH_INPUT_NDOF
"IMAGE_OT_view_ndof",
#endif
/* View2D. */
"VIEW2D_OT_pan",
"VIEW2D_OT_zoom_in",
"VIEW2D_OT_zoom_out",
#ifdef WITH_INPUT_NDOF
"VIEW2D_OT_ndof",
#endif
};
static struct {
wmKeyMapItem *kmi;
wmOperatorType *ot;
} kmi_ot[70];
static int kmi_ot_len;
/* Lazy initialization (avoids having to allocating a context). */
static wmOperatorType *ot_last = NULL;
static char spacetype_last = SPACE_EMPTY;
SpaceLink *sl = CTX_wm_space_data(C);
if ((ot_last != op->type) || (spacetype_last != sl->spacetype)) {
ot_last = op->type;
spacetype_last = sl->spacetype;
wmWindowManager *wm = CTX_wm_manager(C);
wmKeyMap *km;
if (sl->spacetype == SPACE_VIEW3D) {
km = WM_keymap_find_all(wm, "3D View", SPACE_VIEW3D, 0);
}
else if (sl->spacetype == SPACE_IMAGE) {
km = WM_keymap_find_all(wm, "Image", SPACE_IMAGE, 0);
}
else {
km = WM_keymap_find_all(wm, "View2D", 0, 0);
}
kmi_ot_len = 0;
LISTBASE_FOREACH (wmKeyMapItem *, kmi, &km->items) {
if (!(STRPREFIX(kmi->idname, "VIEW") || STRPREFIX(kmi->idname, "IMAGE"))) {
continue;
}
if (kmi->flag & KMI_INACTIVE) {
continue;
}
for (int i = 0; i < ARRAY_SIZE(op_names); i++) {
if (STREQ(kmi->idname, op_names[i])) {
kmi_ot[kmi_ot_len].kmi = kmi;
kmi_ot[kmi_ot_len].ot = WM_operatortype_find(op_names[i], true);
kmi_ot_len++;
break;
}
}
if (kmi_ot_len == ARRAY_SIZE(kmi_ot)) {
BLI_assert(false);
break;
}
}
}
if (event->type == EVT_MODAL_MAP) {
wmWindow *win = CTX_wm_window(C);
event = win->eventstate;
}
for (int i = 0; i < kmi_ot_len; i++) {
if (wm_eventmatch(event, kmi_ot[i].kmi)) {
return WM_operator_name_call_ptr(
C, kmi_ot[i].ot, WM_OP_INVOKE_DEFAULT, kmi_ot[i].kmi->ptr) != OPERATOR_CANCELLED;
}
}
return false;
}
/** \} */