This repository has been archived on 2023-10-09. You can view files and clone it. You cannot open issues or pull requests or push a commit.

Philipp Oeser 2a0e996d77 Fix T80159: Custom Normals Averaging crash after clearing ...

custom split normals data

Clearing custom split normals would get rid of the CD_CUSTOMLOOPNORMAL
layer - but editing data `lnor_spacearr` would be kept.

Adding a CD_CUSTOMLOOPNORMAL layer (if none exists yet) should be done
in `edbm_average_normals_exec` / `BKE_editmesh_lnorspace_update` /
`BM_lnorspace_update` / `BM_lnorspacearr_store`. The thing is that if
the editing data `lnor_spacearr` would still be valid after `Clear
Custom Split Normals Data`, blender would happily call
`BM_lnorspace_rebuild` instead. Doing that without a CD_CUSTOMLOOPNORMAL
layer is asking for trouble.

Now clear lnor_spacearr on `Clear Custom Split Normals Data` as well.

Thx @mont29 for feedback here.

Maniphest Tasks: T80159

Differential Revision: https://developer.blender.org/D8730

2020-08-27 22:12:12 +02:00

..

CMakeLists.txt

CMake: support building without Python

2019-11-25 15:45:49 +11:00

editface.c

Cleanup: use abbreviated names for unsigned types in editors

2020-04-03 16:21:24 +11:00

editmesh_add_gizmo.c

Cleanup: Rename ARegion variables from ar to region

2020-03-06 17:19:23 +01:00

editmesh_add.c

Object: add scale argument to creation operators

2020-05-28 14:34:00 +10:00

editmesh_automerge.c

Edit Mesh: Auto Merge - Split Edges & Faces - Better logic for splitting faces

2020-01-27 08:38:05 -03:00

editmesh_bevel.c

Cleanup: Reduce indentation in function

2020-08-03 17:40:07 -04:00

editmesh_bisect.c

Cleanup: make format after SortedIncludes change

2020-03-19 09:33:58 +01:00

editmesh_extrude_screw.c

Cleanup: make format after SortedIncludes change

2020-03-19 09:33:58 +01:00

editmesh_extrude_spin_gizmo.c

Code Quality: Replace for loops with LISTBASE_FOREACH

2020-04-03 19:27:46 +02:00

editmesh_extrude_spin.c

Cleanup: declare arrays arrays where possible

2020-08-07 22:37:39 +10:00

editmesh_extrude.c

Cleanup: Editors/Mesh, Clang-Tidy else-after-return fixes

2020-07-03 16:15:00 +02:00

editmesh_inset.c

Cleanup: Editors/Mesh, Clang-Tidy else-after-return fixes

2020-07-03 16:15:00 +02:00

editmesh_intersect.c

Cleanup: Editors/Mesh, Clang-Tidy else-after-return fixes

2020-07-03 16:15:00 +02:00

editmesh_knife_project.c

UI: Fixes and small improvements to some labels and UI messages

2020-08-06 14:50:45 +02:00

editmesh_knife.c

GPUState: Use explicit depth test enum

2020-08-20 17:02:39 +02:00

editmesh_loopcut.c

Fix T75588: Missing loop cuts preview for edges without quads

2020-08-11 13:02:37 -03:00

editmesh_mask_extract.c

Fix Mask Slice deleting the Face Sets

2020-08-18 12:20:05 +02:00

editmesh_path.c

Cleanup: Editors/Mesh, Clang-Tidy else-after-return fixes

2020-07-03 16:15:00 +02:00

editmesh_polybuild.c

Cleanup: Editors/Mesh, Clang-Tidy else-after-return fixes

2020-07-03 16:15:00 +02:00

editmesh_preselect_edgering.c

GPUState: Use explicit depth test enum

2020-08-20 17:02:39 +02:00

editmesh_preselect_elem.c

GPUState: Use explicit depth test enum

2020-08-20 17:02:39 +02:00

editmesh_rip_edge.c

Cleanup: make format after SortedIncludes change

2020-03-19 09:33:58 +01:00

editmesh_rip.c

Cleanup: pass arrays const where possible

2020-08-07 22:56:13 +10:00

editmesh_select_similar.c

Cleanup: Editors/Mesh, Clang-Tidy else-after-return fixes

2020-07-03 16:15:00 +02:00

editmesh_select.c

Cleanup: simplify edge loop/boundary select cycling logic

2020-08-26 16:56:24 +10:00

editmesh_tools.c

Cleanup: use array syntax for sizeof with fixed values

2020-08-08 13:38:00 +10:00

editmesh_undo.c

Clang-Tidy: Enable bugprone-misplaced-widening-cast

2020-07-03 17:10:27 +02:00

editmesh_utils.c

Cleanup: remove unused UvVertMap.flag

2020-08-26 21:01:28 +10:00

mesh_data.c

Fix T80159: Custom Normals Averaging crash after clearing

2020-08-27 22:12:12 +02:00

mesh_intern.h

Code Style: use "#pragma once" in source directory

2020-08-07 09:50:34 +02:00

mesh_mirror.c

Cleanup: Editors/Mesh, Clang-Tidy else-after-return fixes

2020-07-03 16:15:00 +02:00

mesh_ops.c

Sculpt Vertex Colors: Initial implementation

2020-06-23 16:28:50 +02:00

meshtools.c

Fix T80077: Objects disappear when joining with a zero scaled axis

2020-08-25 14:32:10 +10:00