A crash in the Freestyle renderer was reported by Ton on IRC with a stack trace below. Note that #2 is in Freestyle, whereas #1 is in the compositor. The problem was observed in a debug build on OS X 10.7 (gcc 4.2, openmp disabled, no llvm). ---------------------------------------------------------------------- Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: 13 at address: 0x0000000000000000 [Switching to process 72386 thread 0xf303] 0x0000000100c129f3 in NodeBase::~NodeBase (this=0x10e501c80) at COM_NodeBase.cpp:43 43 delete (this->m_outputsockets.back()); Current language: auto; currently c++ (gdb) where #0 0x0000000100c129f3 in NodeBase::~NodeBase (this=0x10e501c80) at COM_NodeBase.cpp:43 #1 0x0000000100c29066 in Node::~Node (this=0x10e501c80) at COM_Node.h:49 #2 0x000000010089c273 in NodeShape::~NodeShape (this=0x10e501c80) at NodeShape.cpp:43 #3 0x000000010089910b in NodeGroup::destroy (this=0x10e501da0) at NodeGroup.cpp:61 #4 0x00000001008990cd in NodeGroup::destroy (this=0x10e5014b0) at NodeGroup.cpp:59 #5 0x00000001008990cd in NodeGroup::destroy (this=0x114e18da0) at NodeGroup.cpp:59 #6 0x00000001007e6602 in Controller::ClearRootNode (this=0x114e19640) at Controller.cpp:329 #7 0x00000001007ea52e in Controller::LoadMesh (this=0x114e19640, re=0x10aba4638, srl=0x1140f5258) at Controller.cpp:302 #8 0x00000001008030ad in prepare (re=0x10aba4638, srl=0x1140f5258) at FRS_freestyle.cpp:302 #9 0x000000010080457a in FRS_do_stroke_rendering (re=0x10aba4638, srl=0x1140f5258) at FRS_freestyle.cpp:600 #10 0x00000001006aeb9d in add_freestyle (re=0x10aba4638) at pipeline.c:1584 #11 0x00000001006aceb7 in do_render_3d (re=0x10aba4638) at pipeline.c:1094 #12 0x00000001006ae061 in do_render_fields_blur_3d (re=0x10aba4638) at pipeline.c:1367 #13 0x00000001006afa16 in do_render_composite_fields_blur_3d (re=0x10aba4638) at pipeline.c:1815 #14 0x00000001006b04e4 in do_render_all_options (re=0x10aba4638) at pipeline.c:2021 ---------------------------------------------------------------------- Apparently a name conflict between the two Blender modules is taking place. The present commit hence intends to address it by putting all the Freestyle C++ classes in the namespace 'Freestyle'. This revision will also prevent potential name conflicts with other Blender modules in the future. Special thanks to Lukas Toenne for the help with C++ namespace.
149 lines
3.8 KiB
C++
149 lines
3.8 KiB
C++
/*
|
|
* ***** BEGIN GPL LICENSE BLOCK *****
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
*
|
|
* ***** END GPL LICENSE BLOCK *****
|
|
*/
|
|
|
|
/** \file blender/freestyle/intern/view_map/OccluderSource.cpp
|
|
* \ingroup freestyle
|
|
* \brief Class to define a cell grid surrounding the projected image of a scene
|
|
* \author Alexander Beels
|
|
* \date 2010-12-21
|
|
*/
|
|
|
|
#include <algorithm>
|
|
|
|
#include "OccluderSource.h"
|
|
|
|
#include "BKE_global.h"
|
|
|
|
namespace Freestyle {
|
|
|
|
OccluderSource::OccluderSource(const GridHelpers::Transform& t, WingedEdge& we)
|
|
: wingedEdge(we), valid(false), transform(t)
|
|
{
|
|
begin();
|
|
}
|
|
|
|
OccluderSource::~OccluderSource() {}
|
|
|
|
void OccluderSource::buildCachedPolygon()
|
|
{
|
|
vector<Vec3r> vertices(GridHelpers::enumerateVertices((*currentFace)->getEdgeList()));
|
|
// This doesn't work, because our functor's polymorphism won't survive the copy:
|
|
// std::transform(vertices.begin(), vertices.end(), vertices.begin(), transform);
|
|
// so we have to do:
|
|
for (vector<Vec3r>::iterator i = vertices.begin(); i != vertices.end(); ++i) {
|
|
(*i) = transform(*i);
|
|
}
|
|
cachedPolygon = Polygon3r(vertices, transform((*currentFace)->GetNormal()));
|
|
}
|
|
|
|
void OccluderSource::begin()
|
|
{
|
|
vector<WShape*>& wshapes = wingedEdge.getWShapes();
|
|
currentShape = wshapes.begin();
|
|
shapesEnd = wshapes.end();
|
|
valid = false;
|
|
if (currentShape != shapesEnd) {
|
|
vector<WFace*>& wFaces = (*currentShape)->GetFaceList();
|
|
currentFace = wFaces.begin();
|
|
facesEnd = wFaces.end();
|
|
|
|
if (currentFace != facesEnd) {
|
|
buildCachedPolygon();
|
|
valid = true;
|
|
}
|
|
}
|
|
}
|
|
|
|
bool OccluderSource::next()
|
|
{
|
|
if (valid) {
|
|
++currentFace;
|
|
while (currentFace == facesEnd) {
|
|
++currentShape;
|
|
if (currentShape == shapesEnd) {
|
|
valid = false;
|
|
return false;
|
|
}
|
|
else {
|
|
vector<WFace*>& wFaces = (*currentShape)->GetFaceList();
|
|
currentFace = wFaces.begin();
|
|
facesEnd = wFaces.end();
|
|
}
|
|
}
|
|
buildCachedPolygon();
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool OccluderSource::isValid()
|
|
{
|
|
// Or:
|
|
// return currentShapes != shapesEnd && currentFace != facesEnd;
|
|
return valid;
|
|
}
|
|
|
|
WFace *OccluderSource::getWFace()
|
|
{
|
|
return valid ? *currentFace : NULL;
|
|
}
|
|
|
|
Polygon3r OccluderSource::getCameraSpacePolygon()
|
|
{
|
|
return Polygon3r(GridHelpers::enumerateVertices((*currentFace)->getEdgeList()), (*currentFace)->GetNormal());
|
|
}
|
|
|
|
Polygon3r& OccluderSource::getGridSpacePolygon()
|
|
{
|
|
return cachedPolygon;
|
|
}
|
|
|
|
void OccluderSource::getOccluderProscenium(real proscenium[4])
|
|
{
|
|
begin();
|
|
const Vec3r& initialPoint = cachedPolygon.getVertices()[0];
|
|
proscenium[0] = proscenium[1] = initialPoint[0];
|
|
proscenium[2] = proscenium[3] = initialPoint[1];
|
|
while (isValid()) {
|
|
GridHelpers::expandProscenium (proscenium, cachedPolygon);
|
|
next();
|
|
}
|
|
if (G.debug & G_DEBUG_FREESTYLE) {
|
|
cout << "Proscenium: (" << proscenium[0] << ", " << proscenium[1] << ", " << proscenium[2] << ", " <<
|
|
proscenium[3] << ")" << endl;
|
|
}
|
|
}
|
|
|
|
real OccluderSource::averageOccluderArea()
|
|
{
|
|
real area = 0.0;
|
|
unsigned numFaces = 0;
|
|
for (begin(); isValid(); next()) {
|
|
Vec3r min, max;
|
|
cachedPolygon.getBBox(min, max);
|
|
area += (max[0] - min[0]) * (max[1] - min[1]);
|
|
++numFaces;
|
|
}
|
|
area /= numFaces;
|
|
return area;
|
|
}
|
|
|
|
} /* namespace Freestyle */
|