Sergey Sharybin
1b4f0bf32a
Initial report was mentioning the Classroom demo scene, but this is probably because the scene was pre-configured to be used with OpenCL. Would expect any OpenCL compositing to be failing prior to this fix. The reason why crash was happening is due to OpenCL queue being released from OpenCLDevice destructor. Is not that obvious, but when Vector (including std::vector) is holding elements by value a destructor will be called on "old" memory when vector capacitance changes. Solved by making forbidding copy semantic for compositor devices and forcing move semantic to be used. Also use emplace semantic in the devices vector initialization.
61 lines
1.6 KiB
C++
61 lines
1.6 KiB
C++
/*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
*
|
|
* Copyright 2011, Blender Foundation.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "COM_WorkPackage.h"
|
|
|
|
namespace blender::compositor {
|
|
|
|
/**
|
|
* \brief Abstract class for device implementations to be used by the Compositor.
|
|
* devices are queried, initialized and used by the WorkScheduler.
|
|
* work are packaged as a WorkPackage instance.
|
|
*/
|
|
class Device {
|
|
|
|
public:
|
|
Device() = default;
|
|
|
|
Device(const Device &other) = delete;
|
|
Device(Device &&other) noexcept = default;
|
|
|
|
Device &operator=(const Device &other) = delete;
|
|
Device &operator=(Device &&other) = delete;
|
|
|
|
/**
|
|
* \brief Declaration of the virtual destructor
|
|
* \note resolve warning gcc 4.7
|
|
*/
|
|
virtual ~Device()
|
|
{
|
|
}
|
|
|
|
/**
|
|
* \brief execute a WorkPackage
|
|
* \param work: the WorkPackage to execute
|
|
*/
|
|
virtual void execute(struct WorkPackage *work) = 0;
|
|
|
|
#ifdef WITH_CXX_GUARDEDALLOC
|
|
MEM_CXX_CLASS_ALLOC_FUNCS("COM:Device")
|
|
#endif
|
|
};
|
|
|
|
} // namespace blender::compositor
|