fbc884d2a8
Currently, the `eval` and `pdf` are not explicitly set to zero when a BSDF sample is invalid (e.g., below the upper hemisphere), when calling `bsdf_sample` or `bsdf_eval`. It is assumed that `eval` and `pdf` are set to zero before these functions are called, which can cause problems if not. This patch fixes this potential problem by explicitly setting `eval` and `pdf` to zero when the sampled direction is invalid. I also added a sanity check if `eval` and `pdf` are valid (i.e., >= 0.f). The check is activated when build in debug mode and with the `WITH_CYCLES_DEBUG` set to `ON`. Reviewed By: brecht, sergey Differential Revision: https://developer.blender.org/D14776
77 lines
2.4 KiB
C++
77 lines
2.4 KiB
C++
/* SPDX-License-Identifier: BSD-3-Clause
|
|
*
|
|
* Adapted from Open Shading Language
|
|
* Copyright (c) 2009-2010 Sony Pictures Imageworks Inc., et al.
|
|
* All Rights Reserved.
|
|
*
|
|
* Modifications Copyright 2011-2022 Blender Foundation. */
|
|
|
|
#pragma once
|
|
|
|
CCL_NAMESPACE_BEGIN
|
|
|
|
/* REFLECTION */
|
|
|
|
ccl_device int bsdf_reflection_setup(ccl_private MicrofacetBsdf *bsdf)
|
|
{
|
|
bsdf->type = CLOSURE_BSDF_REFLECTION_ID;
|
|
return SD_BSDF;
|
|
}
|
|
|
|
ccl_device float3 bsdf_reflection_eval_reflect(ccl_private const ShaderClosure *sc,
|
|
const float3 I,
|
|
const float3 omega_in,
|
|
ccl_private float *pdf)
|
|
{
|
|
*pdf = 0.0f;
|
|
return make_float3(0.0f, 0.0f, 0.0f);
|
|
}
|
|
|
|
ccl_device float3 bsdf_reflection_eval_transmit(ccl_private const ShaderClosure *sc,
|
|
const float3 I,
|
|
const float3 omega_in,
|
|
ccl_private float *pdf)
|
|
{
|
|
*pdf = 0.0f;
|
|
return make_float3(0.0f, 0.0f, 0.0f);
|
|
}
|
|
|
|
ccl_device int bsdf_reflection_sample(ccl_private const ShaderClosure *sc,
|
|
float3 Ng,
|
|
float3 I,
|
|
float3 dIdx,
|
|
float3 dIdy,
|
|
float randu,
|
|
float randv,
|
|
ccl_private float3 *eval,
|
|
ccl_private float3 *omega_in,
|
|
ccl_private float3 *domega_in_dx,
|
|
ccl_private float3 *domega_in_dy,
|
|
ccl_private float *pdf)
|
|
{
|
|
ccl_private const MicrofacetBsdf *bsdf = (ccl_private const MicrofacetBsdf *)sc;
|
|
float3 N = bsdf->N;
|
|
|
|
// only one direction is possible
|
|
float cosNO = dot(N, I);
|
|
if (cosNO > 0) {
|
|
*omega_in = (2 * cosNO) * N - I;
|
|
if (dot(Ng, *omega_in) > 0) {
|
|
#ifdef __RAY_DIFFERENTIALS__
|
|
*domega_in_dx = 2 * dot(N, dIdx) * N - dIdx;
|
|
*domega_in_dy = 2 * dot(N, dIdy) * N - dIdy;
|
|
#endif
|
|
/* Some high number for MIS. */
|
|
*pdf = 1e6f;
|
|
*eval = make_float3(1e6f, 1e6f, 1e6f);
|
|
}
|
|
}
|
|
else {
|
|
*pdf = 0.0f;
|
|
*eval = make_float3(0.0f, 0.0f, 0.0f);
|
|
}
|
|
return LABEL_REFLECT | LABEL_SINGULAR;
|
|
}
|
|
|
|
CCL_NAMESPACE_END
|