This is mainly a maintenance commit which was aimed to make work with this module more pleasant and solve such issues as: - Annoyance with looong files, which had craftload in them - Usage of STL for the data structures we've got in BLI - Possible symbol conflicts - Not real clear layout of what is located where So in this commit the following changes are done: - STL is prohibited, it's not really predictable on various compilers, with our BLI algorithms we can predict things much better. There are still few usages of std::vector, but that we'll be solving later once we've got similar thing in BLI. - Simplify foreach loops, avoid using const_iterator all over the place. - New directory layout, which is hopefully easier to follow. - Some files were split, some of them will be split soon. The idea of this is to split huge functions into own files with good documentation and everything. - Removed stuff which was planned for use in the future but was never finished, tested or anything. Let's wipe it out for now, and bring back once we really start using it, so it'll be more clear if it solves our needs. - All the internal routines were moved to DEG namespace to separate them better from rest of blender. Some places now annoyingly using DEG::foo, but that we can olve by moving some utility functions inside of the namespace. While working on this we've found some hotspot in updates flush, so now playback of blenrig is few percent faster (something like 96fps with previous master and around 99-100fps after this change). Not saying it's something final, there is still room for cleanup and API simplification, but those might happen as a regular development now without doing any global changes.
244 lines
6.8 KiB
C++
244 lines
6.8 KiB
C++
/*
|
|
* ***** BEGIN GPL LICENSE BLOCK *****
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
*
|
|
* The Original Code is Copyright (C) 2014 Blender Foundation.
|
|
* All rights reserved.
|
|
*
|
|
* Original Author: Lukas Toenne
|
|
* Contributor(s): None Yet
|
|
*
|
|
* ***** END GPL LICENSE BLOCK *****
|
|
*/
|
|
|
|
/** \file blender/depsgraph/intern/depsgraph_debug.cc
|
|
* \ingroup depsgraph
|
|
*
|
|
* Implementation of tools for debugging the depsgraph
|
|
*/
|
|
|
|
#include "BLI_utildefines.h"
|
|
#include "BLI_ghash.h"
|
|
|
|
extern "C" {
|
|
#include "DNA_scene_types.h"
|
|
|
|
#include "DEG_depsgraph.h"
|
|
#include "DEG_depsgraph_debug.h"
|
|
#include "DEG_depsgraph_build.h"
|
|
} /* extern "C" */
|
|
|
|
#include "intern/eval/deg_eval_debug.h"
|
|
#include "intern/depsgraph_intern.h"
|
|
#include "util/deg_util_foreach.h"
|
|
|
|
/* ************************************************ */
|
|
|
|
DepsgraphStats *DEG_stats(void)
|
|
{
|
|
return DEG::DepsgraphDebug::stats;
|
|
}
|
|
|
|
void DEG_stats_verify()
|
|
{
|
|
DEG::DepsgraphDebug::verify_stats();
|
|
}
|
|
|
|
DepsgraphStatsID *DEG_stats_id(ID *id)
|
|
{
|
|
if (!DEG::DepsgraphDebug::stats) {
|
|
return NULL;
|
|
}
|
|
return DEG::DepsgraphDebug::get_id_stats(id, false);
|
|
}
|
|
|
|
bool DEG_debug_compare(const struct Depsgraph *graph1,
|
|
const struct Depsgraph *graph2)
|
|
{
|
|
BLI_assert(graph1 != NULL);
|
|
BLI_assert(graph2 != NULL);
|
|
const DEG::Depsgraph *deg_graph1 = reinterpret_cast<const DEG::Depsgraph *>(graph1);
|
|
const DEG::Depsgraph *deg_graph2 = reinterpret_cast<const DEG::Depsgraph *>(graph2);
|
|
if (deg_graph1->operations.size() != deg_graph2->operations.size()) {
|
|
return false;
|
|
}
|
|
/* TODO(sergey): Currently we only do real stupid check,
|
|
* which is fast but which isn't 100% reliable.
|
|
*
|
|
* Would be cool to make it more robust, but it's good enough
|
|
* for now. Also, proper graph check is actually NP-complex
|
|
* problem..
|
|
*/
|
|
return true;
|
|
}
|
|
|
|
bool DEG_debug_scene_relations_validate(Main *bmain,
|
|
Scene *scene)
|
|
{
|
|
Depsgraph *depsgraph = DEG_graph_new();
|
|
bool valid = true;
|
|
DEG_graph_build_from_scene(depsgraph, bmain, scene);
|
|
if (!DEG_debug_compare(depsgraph, scene->depsgraph)) {
|
|
fprintf(stderr, "ERROR! Depsgraph wasn't tagged for update when it should have!\n");
|
|
BLI_assert(!"This should not happen!");
|
|
valid = false;
|
|
}
|
|
DEG_graph_free(depsgraph);
|
|
return valid;
|
|
}
|
|
|
|
bool DEG_debug_consistency_check(Depsgraph *graph)
|
|
{
|
|
const DEG::Depsgraph *deg_graph = reinterpret_cast<const DEG::Depsgraph *>(graph);
|
|
|
|
/* Validate links exists in both directions. */
|
|
foreach (DEG::OperationDepsNode *node, deg_graph->operations) {
|
|
foreach (DEG::DepsRelation *rel, node->outlinks) {
|
|
int counter1 = 0;
|
|
foreach (DEG::DepsRelation *tmp_rel, node->outlinks) {
|
|
if (tmp_rel == rel) {
|
|
++counter1;
|
|
}
|
|
}
|
|
|
|
int counter2 = 0;
|
|
foreach (DEG::DepsRelation *tmp_rel, rel->to->inlinks) {
|
|
if (tmp_rel == rel) {
|
|
++counter2;
|
|
}
|
|
}
|
|
|
|
if (counter1 != counter2) {
|
|
printf("Relation exists in outgoing direction but not in incoming (%d vs. %d).\n",
|
|
counter1, counter2);
|
|
return false;
|
|
}
|
|
}
|
|
}
|
|
|
|
foreach (DEG::OperationDepsNode *node, deg_graph->operations) {
|
|
foreach (DEG::DepsRelation *rel, node->inlinks) {
|
|
int counter1 = 0;
|
|
foreach (DEG::DepsRelation *tmp_rel, node->inlinks) {
|
|
if (tmp_rel == rel) {
|
|
++counter1;
|
|
}
|
|
}
|
|
|
|
int counter2 = 0;
|
|
foreach (DEG::DepsRelation *tmp_rel, rel->from->outlinks) {
|
|
if (tmp_rel == rel) {
|
|
++counter2;
|
|
}
|
|
}
|
|
|
|
if (counter1 != counter2) {
|
|
printf("Relation exists in incoming direction but not in outcoming (%d vs. %d).\n",
|
|
counter1, counter2);
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Validate node valency calculated in both directions. */
|
|
foreach (DEG::OperationDepsNode *node, deg_graph->operations) {
|
|
node->num_links_pending = 0;
|
|
node->done = 0;
|
|
}
|
|
|
|
foreach (DEG::OperationDepsNode *node, deg_graph->operations) {
|
|
if (node->done) {
|
|
printf("Node %s is twice in the operations!\n",
|
|
node->identifier().c_str());
|
|
return false;
|
|
}
|
|
foreach (DEG::DepsRelation *rel, node->outlinks) {
|
|
if (rel->to->type == DEG::DEPSNODE_TYPE_OPERATION) {
|
|
DEG::OperationDepsNode *to = (DEG::OperationDepsNode *)rel->to;
|
|
BLI_assert(to->num_links_pending < to->inlinks.size());
|
|
++to->num_links_pending;
|
|
}
|
|
}
|
|
node->done = 1;
|
|
}
|
|
|
|
foreach (DEG::OperationDepsNode *node, deg_graph->operations) {
|
|
int num_links_pending = 0;
|
|
foreach (DEG::DepsRelation *rel, node->inlinks) {
|
|
if (rel->from->type == DEG::DEPSNODE_TYPE_OPERATION) {
|
|
++num_links_pending;
|
|
}
|
|
}
|
|
if (node->num_links_pending != num_links_pending) {
|
|
printf("Valency mismatch: %s, %u != %d\n",
|
|
node->identifier().c_str(),
|
|
node->num_links_pending, num_links_pending);
|
|
printf("Number of inlinks: %d\n", (int)node->inlinks.size());
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
/* ------------------------------------------------ */
|
|
|
|
/**
|
|
* Obtain simple statistics about the complexity of the depsgraph
|
|
* \param[out] r_outer The number of outer nodes in the graph
|
|
* \param[out] r_operations The number of operation nodes in the graph
|
|
* \param[out] r_relations The number of relations between (executable) nodes in the graph
|
|
*/
|
|
void DEG_stats_simple(const Depsgraph *graph, size_t *r_outer,
|
|
size_t *r_operations, size_t *r_relations)
|
|
{
|
|
const DEG::Depsgraph *deg_graph = reinterpret_cast<const DEG::Depsgraph *>(graph);
|
|
|
|
/* number of operations */
|
|
if (r_operations) {
|
|
/* All operations should be in this list, allowing us to count the total
|
|
* number of nodes.
|
|
*/
|
|
*r_operations = deg_graph->operations.size();
|
|
}
|
|
|
|
/* Count number of outer nodes and/or relations between these. */
|
|
if (r_outer || r_relations) {
|
|
size_t tot_outer = 0;
|
|
size_t tot_rels = 0;
|
|
|
|
GHASH_FOREACH_BEGIN(DEG::IDDepsNode *, id_node, deg_graph->id_hash)
|
|
{
|
|
tot_outer++;
|
|
GHASH_FOREACH_BEGIN(DEG::ComponentDepsNode *, comp_node, id_node->components)
|
|
{
|
|
tot_outer++;
|
|
foreach (DEG::OperationDepsNode *op_node, comp_node->operations) {
|
|
tot_rels += op_node->inlinks.size();
|
|
}
|
|
}
|
|
GHASH_FOREACH_END();
|
|
}
|
|
GHASH_FOREACH_END();
|
|
|
|
DEG::TimeSourceDepsNode *time_source = deg_graph->find_time_source(NULL);
|
|
if (time_source != NULL) {
|
|
tot_rels += time_source->inlinks.size();
|
|
}
|
|
|
|
if (r_relations) *r_relations = tot_rels;
|
|
if (r_outer) *r_outer = tot_outer;
|
|
}
|
|
}
|