Julian Eisel
a958ae36e8
Various UI code would store the `AssetHandle` in a way that turns out to be unsafe. The file-data is part of the file browser caching system that releases file-data when a certain maximum of items is in the cache. So even while just iterating over the assets, earlier iterated asset handles may become invalid. Now asset handles are really treated as volatile, short lived objects. For the asset-view, the fix was more involved. There we need an RNA collection of asset-handles, because the UI list code requires that. So we create a dummy collection and get the asset handles as needed by index. This again meant that I had to keep the index of the collection and the asset-list in sync, so all filtering had to be moved to the UI list. I tried duplicating the file-data out of the cache instead, but that caused problems with managing the memory/ownership of the preview images. `AssetHandle` should be removed and replaced by `AssetRepresentation`, but this would be an even more disruptive change (breaking API compatibility too). Fixes #104305, #105535. Pull Request: #105773
67 lines
1.6 KiB
C++
67 lines
1.6 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
/** \file
|
|
* \ingroup edasset
|
|
*/
|
|
|
|
#include <string>
|
|
|
|
#include "AS_asset_representation.h"
|
|
#include "AS_asset_representation.hh"
|
|
|
|
#include "BLI_string.h"
|
|
|
|
#include "DNA_space_types.h"
|
|
|
|
#include "ED_asset_handle.h"
|
|
|
|
AssetRepresentation *ED_asset_handle_get_representation(const AssetHandle *asset)
|
|
{
|
|
return asset->file_data->asset;
|
|
}
|
|
|
|
const char *ED_asset_handle_get_name(const AssetHandle *asset)
|
|
{
|
|
return AS_asset_representation_name_get(asset->file_data->asset);
|
|
}
|
|
|
|
AssetMetaData *ED_asset_handle_get_metadata(const AssetHandle *asset_handle)
|
|
{
|
|
return AS_asset_representation_metadata_get(asset_handle->file_data->asset);
|
|
}
|
|
|
|
ID *ED_asset_handle_get_local_id(const AssetHandle *asset)
|
|
{
|
|
return asset->file_data->id;
|
|
}
|
|
|
|
ID_Type ED_asset_handle_get_id_type(const AssetHandle *asset)
|
|
{
|
|
return static_cast<ID_Type>(asset->file_data->blentype);
|
|
}
|
|
|
|
int ED_asset_handle_get_preview_icon_id(const AssetHandle *asset)
|
|
{
|
|
return asset->file_data->preview_icon_id;
|
|
}
|
|
|
|
std::optional<eAssetImportMethod> ED_asset_handle_get_import_method(
|
|
const AssetHandle *asset_handle)
|
|
{
|
|
return AS_asset_representation_import_method_get(asset_handle->file_data->asset);
|
|
}
|
|
|
|
void ED_asset_handle_get_full_library_path(const AssetHandle *asset_handle,
|
|
char r_full_lib_path[FILE_MAX_LIBEXTRA])
|
|
{
|
|
*r_full_lib_path = '\0';
|
|
|
|
std::string library_path = AS_asset_representation_full_library_path_get(
|
|
asset_handle->file_data->asset);
|
|
if (library_path.empty()) {
|
|
return;
|
|
}
|
|
|
|
BLI_strncpy(r_full_lib_path, library_path.c_str(), FILE_MAX);
|
|
}
|