Lukas Tönne
67134a7bf6
EWA sampling is designed for downsampling images, i.e. scaling down the size of input image pixels, which happens regularly in compositing. While the standard sampling methods (linear, cubic) work reasonably well for linear transformations, they don't yield good results in non-linear cases like perspective projection or arbitrary displacement. EWA sampling is comparable to mipmapping, but avoids problems with discontinuities. To work correctly the EWA algorithm needs partial derivatives of the mapping functions which convert output pixel coordinates back into the input image space (2x2 Jacobian matrix). With these derivatives the EWA algorithm projects ellipses into the input space and accumulates colors over their area. This calculation was not done correctly in the compositor, only the derivatives du/dx and dv/dy were calculation, basically this means it only worked for non-rotated input images. The patch introduces full derivative calculations du/dx, du/dy, dv/dx, dv/dy for the 3 nodes which use EWA sampling currently: PlaneTrackWarp, MapUV and Displace. In addition the calculation of ellipsis area and axis-aligned bounding boxes has been fixed. For the MapUV and Displace nodes the derivatives have to be estimated by evaluating the UV/displacement inputs with 1-pixel offsets, which can still have problems on discontinuities and sub-pixel variations. These potential problems can only be alleviated by more radical design changes in the compositor functions, which are out of scope for now. Basically the values passed to the UV/Displacement inputs would need to be associated with their 1st order derivatives, which requires a general approach to derivatives in all nodes.
120 lines
3.6 KiB
C++
120 lines
3.6 KiB
C++
/*
|
|
* Copyright 2011, Blender Foundation.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
*
|
|
* Contributor:
|
|
* Jeroen Bakker
|
|
* Monique Dewanchand
|
|
*/
|
|
|
|
#include "COM_ReadBufferOperation.h"
|
|
#include "COM_WriteBufferOperation.h"
|
|
#include "COM_defines.h"
|
|
|
|
ReadBufferOperation::ReadBufferOperation() : NodeOperation()
|
|
{
|
|
this->addOutputSocket(COM_DT_COLOR);
|
|
this->m_single_value = false;
|
|
this->m_offset = 0;
|
|
this->m_buffer = NULL;
|
|
}
|
|
|
|
void *ReadBufferOperation::initializeTileData(rcti *rect)
|
|
{
|
|
return m_buffer;
|
|
}
|
|
|
|
void ReadBufferOperation::determineResolution(unsigned int resolution[2], unsigned int preferredResolution[2])
|
|
{
|
|
if (this->m_memoryProxy != NULL) {
|
|
WriteBufferOperation *operation = this->m_memoryProxy->getWriteBufferOperation();
|
|
operation->determineResolution(resolution, preferredResolution);
|
|
operation->setResolution(resolution);
|
|
|
|
/// @todo: may not occur!, but does with blur node
|
|
if (this->m_memoryProxy->getExecutor()) {
|
|
this->m_memoryProxy->getExecutor()->setResolution(resolution);
|
|
}
|
|
|
|
m_single_value = operation->isSingleValue();
|
|
}
|
|
}
|
|
void ReadBufferOperation::executePixelSampled(float output[4], float x, float y, PixelSampler sampler)
|
|
{
|
|
if (m_single_value) {
|
|
/* write buffer has a single value stored at (0,0) */
|
|
m_buffer->read(output, 0, 0);
|
|
}
|
|
else if (sampler == COM_PS_NEAREST) {
|
|
m_buffer->read(output, x, y);
|
|
}
|
|
else {
|
|
m_buffer->readBilinear(output, x, y);
|
|
}
|
|
}
|
|
|
|
void ReadBufferOperation::executePixelExtend(float output[4], float x, float y, PixelSampler sampler,
|
|
MemoryBufferExtend extend_x, MemoryBufferExtend extend_y)
|
|
{
|
|
if (m_single_value) {
|
|
/* write buffer has a single value stored at (0,0) */
|
|
m_buffer->read(output, 0, 0);
|
|
}
|
|
else if (sampler == COM_PS_NEAREST) {
|
|
m_buffer->read(output, x, y, extend_x, extend_y);
|
|
}
|
|
else {
|
|
m_buffer->readBilinear(output, x, y, extend_x, extend_y);
|
|
}
|
|
}
|
|
|
|
void ReadBufferOperation::executePixelFiltered(float output[4], float x, float y, float dx[2], float dy[2], PixelSampler sampler)
|
|
{
|
|
if (m_single_value) {
|
|
/* write buffer has a single value stored at (0,0) */
|
|
m_buffer->read(output, 0, 0);
|
|
}
|
|
else {
|
|
const float uv[2] = { x, y };
|
|
const float deriv[2][2] = { {dx[0], dx[1]}, {dy[0], dy[1]} };
|
|
m_buffer->readEWA(output, uv, deriv, sampler);
|
|
}
|
|
}
|
|
|
|
bool ReadBufferOperation::determineDependingAreaOfInterest(rcti *input, ReadBufferOperation *readOperation, rcti *output)
|
|
{
|
|
if (this == readOperation) {
|
|
BLI_rcti_init(output, input->xmin, input->xmax, input->ymin, input->ymax);
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
void ReadBufferOperation::readResolutionFromWriteBuffer()
|
|
{
|
|
if (this->m_memoryProxy != NULL) {
|
|
WriteBufferOperation *operation = this->m_memoryProxy->getWriteBufferOperation();
|
|
this->setWidth(operation->getWidth());
|
|
this->setHeight(operation->getHeight());
|
|
}
|
|
}
|
|
|
|
void ReadBufferOperation::updateMemoryBuffer()
|
|
{
|
|
this->m_buffer = this->getMemoryProxy()->getBuffer();
|
|
|
|
}
|