archive/blender-asset-manager
Archived
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Added a BlendFileError exception

Browse Source 
This avoid having to raise (and catch) an Exception instance. Catching
such an exception is unnecessarily broad, as it'll also catch things like
SyntaxError and AttributeError.
This commit is contained in:
Sybren A. Stüvel
2017-04-12 11:01:39 +02:00
parent 250c35ce12
commit 9fbb3801bb
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
bam/blend/blendfile.py
View File

@@ -30,6 +30,10 @@ log = logging.getLogger("blendfile")
FILE_BUFFER_SIZE = 1024 * 1024 FILE_BUFFER_SIZE = 1024 * 1024
class BlendFileError(Exception):
"""Raised when there was an error reading/parsing a blend file."""
# ----------------------------------------------------------------------------- # -----------------------------------------------------------------------------
# module global routines # module global routines
# #
@@ -73,9 +77,9 @@ def open_blend(filename, access="rb"):
bfile.filepath_orig = filename bfile.filepath_orig = filename
return bfile return bfile
else: else:
raise Exception("filetype inside gzip not a blend") raise BlendFileError("filetype inside gzip not a blend")
else: else:
raise Exception("filetype not a blend or a gzip blend") raise BlendFileError("filetype not a blend or a gzip blend")
def pad_up_4(offset): def pad_up_4(offset):
@@ -143,7 +147,7 @@ class BlendFile:
self.blocks.append(block) self.blocks.append(block)
if not self.structs: if not self.structs:
raise Exception("No DNA1 block in file, this is not a valid .blend file!") raise BlendFileError("No DNA1 block in file, this is not a valid .blend file!")
# cache (could lazy init, incase we never use?) # cache (could lazy init, incase we never use?)
self.block_from_offset = {block.addr_old: block for block in self.blocks if block.code != b'ENDB'} self.block_from_offset = {block.addr_old: block for block in self.blocks if block.code != b'ENDB'}