Address comments on 2e45bf637a

This commit is contained in:
Ellwood Zwovic
2017-07-14 21:15:00 -07:00
parent 74f10ba3cd
commit f588e3f619
2 changed files with 11 additions and 8 deletions

View File

@@ -255,7 +255,7 @@ class BPKG_OT_refresh(SubprocMixin, bpy.types.Operator):
subproc.SubprocError: self._subproc_error, subproc.SubprocError: self._subproc_error,
subproc.DownloadError: self._subproc_download_error, subproc.DownloadError: self._subproc_download_error,
subproc.Success: self._subproc_success, subproc.Success: self._subproc_success,
subproc.Result: self._subproc_result, subproc.RepositoryResult: self._subproc_repository_result,
subproc.Aborted: self._subproc_aborted, subproc.Aborted: self._subproc_aborted,
} }
@@ -283,9 +283,9 @@ class BPKG_OT_refresh(SubprocMixin, bpy.types.Operator):
self.report({'INFO'}, 'Package list retrieved successfully') self.report({'INFO'}, 'Package list retrieved successfully')
self.quit() self.quit()
def _subproc_result(self, result: subproc.Result): def _subproc_repository_result(self, result: subproc.RepositoryResult):
prefs = bpy.context.user_preferences.addons[__package__].preferences prefs = bpy.context.user_preferences.addons[__package__].preferences
prefs['repo'] = result.data prefs['repo'] = result.repository
self.report({'INFO'}, 'Package list retrieved successfully') self.report({'INFO'}, 'Package list retrieved successfully')
self.quit() self.quit()

View File

@@ -66,11 +66,11 @@ class DownloadError(SubprocMessage):
class Success(SubprocMessage): class Success(SubprocMessage):
"""Sent when an operation finished sucessfully.""" """Sent when an operation finished sucessfully."""
class Result(SubprocMessage): class RepositoryResult(SubprocMessage):
"""Sent when an operation returns data to be used on the parent process.""" """Sent when an operation returns a repository to be used on the parent process."""
def __init__(self, data): def __init__(self, repository: dict):
self.data = data self.repository = repository
class Aborted(SubprocMessage): class Aborted(SubprocMessage):
"""Sent as response to Abort message.""" """Sent as response to Abort message."""
@@ -489,7 +489,10 @@ def refresh(pipe_to_blender, storage_path: pathlib.Path, repository_url: str):
return return
repo.to_file(repo_path) # TODO: this always writes even if repo wasn't changed repo.to_file(repo_path) # TODO: this always writes even if repo wasn't changed
pipe_to_blender.send(Result(repo.to_dict(sort=True))) pipe_to_blender.send(RepositoryResult(repo.to_dict(sort=True)))
def load(pipe_to_blender, storage_path: pathlib.Path):
"""Reads the stored repository"""
def debug_hang(): def debug_hang():
"""Hangs for an hour. For testing purposes only.""" """Hangs for an hour. For testing purposes only."""