2012-02-24 15:04:53 -08:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Copyright 2012 Facebook, Inc.
|
|
|
|
|
*
|
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
|
*
|
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
*
|
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
|
* limitations under the License.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
final class PhabricatorAuditAddCommentController
|
|
|
|
|
extends PhabricatorAuditController {
|
|
|
|
|
|
|
|
|
|
public function processRequest() {
|
|
|
|
|
$request = $this->getRequest();
|
|
|
|
|
$user = $request->getUser();
|
|
|
|
|
|
|
|
|
|
if (!$request->isFormPost()) {
|
|
|
|
|
return new Aphront403Response();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$commit_phid = $request->getStr('commit');
|
|
|
|
|
$commit = id(new PhabricatorRepositoryCommit())->loadOneWhere(
|
|
|
|
|
'phid = %s',
|
|
|
|
|
$commit_phid);
|
|
|
|
|
|
|
|
|
|
if (!$commit) {
|
|
|
|
|
return new Aphront404Response();
|
|
|
|
|
}
|
|
|
|
|
|
2012-04-23 13:50:04 -07:00
|
|
|
$phids = array($commit_phid);
|
|
|
|
|
|
|
|
|
|
$action = $request->getStr('action');
|
|
|
|
|
|
2012-02-24 15:04:53 -08:00
|
|
|
$comment = id(new PhabricatorAuditComment())
|
2012-04-23 13:50:04 -07:00
|
|
|
->setAction($action)
|
2012-02-24 15:04:53 -08:00
|
|
|
->setContent($request->getStr('content'));
|
|
|
|
|
|
2012-04-23 13:50:04 -07:00
|
|
|
$auditors = $request->getArr('auditors');
|
|
|
|
|
$ccs = $request->getArr('ccs');
|
2012-02-27 13:00:23 -08:00
|
|
|
|
2012-02-24 15:04:53 -08:00
|
|
|
id(new PhabricatorAuditCommentEditor($commit))
|
|
|
|
|
->setUser($user)
|
Add inline comments to Diffusion/Audit
Summary:
- Add inline comments to Audits, like Differential.
- Creates new storage for the comments in the Audits database.
- Creates a new PhabricatorAuditInlineComment class, similar to DifferentialInlineComment.
- Defines an Interface which Differential and Audit comments conform to.
- Makes consumers of DifferentialInlineComments consume objects which implement that interface instead.
- Adds save
NOTE: Some features are still missing! Wanted to cut this off before it got crazy:
- Inline comments aren't shown in the main comment list.
- Inline comments aren't shown in the emails.
- Inline comments aren't previewed.
I'll followup with those but this was getting pretty big.
@vrana, does the SQL change look correct?
Test Plan:
- Created, edited, deleted, replied to, reloaded and saved inline comments in Diffusion, on the left and right side of diffs.
- Created, edited, deleted, replied to, reloaded and saved inline comments in Differentila, on the left and right side of primary and diff-versus-diff diffs.
Reviewers: btrahan, vrana
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T904
Differential Revision: https://secure.phabricator.com/D1898
2012-03-14 12:56:01 -07:00
|
|
|
->setAttachInlineComments(true)
|
2012-04-23 13:50:04 -07:00
|
|
|
->addAuditors($auditors)
|
|
|
|
|
->addCCs($ccs)
|
2012-02-24 15:04:53 -08:00
|
|
|
->addComment($comment);
|
|
|
|
|
|
|
|
|
|
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
|
|
|
|
|
$uri = $handles[$commit_phid]->getURI();
|
|
|
|
|
|
2012-02-27 13:00:23 -08:00
|
|
|
$draft = id(new PhabricatorDraft())->loadOneWhere(
|
|
|
|
|
'authorPHID = %s AND draftKey = %s',
|
|
|
|
|
$user->getPHID(),
|
|
|
|
|
'diffusion-audit-'.$commit->getID());
|
|
|
|
|
if ($draft) {
|
|
|
|
|
$draft->delete();
|
|
|
|
|
}
|
|
|
|
|
|
2012-02-24 15:04:53 -08:00
|
|
|
return id(new AphrontRedirectResponse())->setURI($uri);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
}
|