2012-04-30 07:53:53 -07:00
|
|
|
CREATE TABLE {$NAMESPACE}_audit.audit_inlinecomment (
|
Add inline comments to Diffusion/Audit
Summary:
- Add inline comments to Audits, like Differential.
- Creates new storage for the comments in the Audits database.
- Creates a new PhabricatorAuditInlineComment class, similar to DifferentialInlineComment.
- Defines an Interface which Differential and Audit comments conform to.
- Makes consumers of DifferentialInlineComments consume objects which implement that interface instead.
- Adds save
NOTE: Some features are still missing! Wanted to cut this off before it got crazy:
- Inline comments aren't shown in the main comment list.
- Inline comments aren't shown in the emails.
- Inline comments aren't previewed.
I'll followup with those but this was getting pretty big.
@vrana, does the SQL change look correct?
Test Plan:
- Created, edited, deleted, replied to, reloaded and saved inline comments in Diffusion, on the left and right side of diffs.
- Created, edited, deleted, replied to, reloaded and saved inline comments in Differentila, on the left and right side of primary and diff-versus-diff diffs.
Reviewers: btrahan, vrana
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T904
Differential Revision: https://secure.phabricator.com/D1898
2012-03-14 12:56:01 -07:00
|
|
|
id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
|
|
|
|
|
authorPHID varchar(64) COLLATE utf8_bin NOT NULL,
|
|
|
|
|
commitPHID varchar(64) COLLATE utf8_bin NOT NULL,
|
|
|
|
|
pathID INT UNSIGNED NOT NULL,
|
|
|
|
|
auditCommentID INT UNSIGNED,
|
|
|
|
|
isNewFile BOOL NOT NULL,
|
|
|
|
|
lineNumber INT UNSIGNED NOT NULL,
|
|
|
|
|
lineLength INT UNSIGNED NOT NULL,
|
|
|
|
|
content LONGTEXT COLLATE utf8_bin,
|
|
|
|
|
cache LONGTEXT COLLATE utf8_bin,
|
|
|
|
|
dateCreated INT UNSIGNED NOT NULL,
|
|
|
|
|
dateModified INT UNSIGNED NOT NULL,
|
|
|
|
|
KEY (commitPHID, pathID),
|
|
|
|
|
KEY (authorPHID, commitPHID, auditCommentID)
|
|
|
|
|
) ENGINE=InnoDB, COLLATE utf8_general_ci;
|