phabricator/resources/sql/patches/101.heraldruleapplied.sql

ALTER TABLE {$NAMESPACE}_herald.herald_ruleapplied
  ADD KEY (phid);
SQL Patch Management: SQL Changes Summary: Splits out the SQL changes. These are most of the changes, but primarily mechanical: - Moved "initialize.sql" to "0000.legacy.sql" and partially reverted to an older version, such that patches 0000 + 000 + 001 + ... + 137 put us in the right state when applied sequentially. - Removed "create database" commands from all SQL. These are handled by separate DB patches now, so we have the data to do operations like "storage databases" (list databases) and "storage destroy" (drop databases). - Removed "phabricator_" namespace from all SQL, and replaced with "{$NAMESPACE}_" token so we can namespace databases. - Shortened some column lengths so patches apply correctly if originally created as InnoDB; also a few similar tweaks elsewhere. Test Plan: See D2323 for discussion and test plan. Reviewers: edward, vrana, btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T140, T345 Differential Revision: https://secure.phabricator.com/D2329 2012-04-30 07:53:53 -07:00			`ALTER TABLE {$NAMESPACE}_herald.herald_ruleapplied`
Remove massive "rule applied" query Summary: Herald rules may be marked as "one-time". We track this by writing a row with <ruleID, phid> when we apply a rule. However, the current test for rule application involves loading every <ruleID, > pair. We also always write this row even for rules which are not one-time, so if there are 100 rules, we'll load 1,000,000 rows after processing 10,000 objects. Instead, load only the <phid, > pairs, which are guaranteed to be bounded to at most the number of rules. I'll follow up with a diff that causes us to write rows only for one-time rules, and deletes all historic rows which are not associated with one-time rules. Test Plan: Grepped for callsites to loadAllByContentTypeWithFullData(). Ran rules in test console. Reviewers: nh, btrahan, jungejason Reviewed By: nh CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1483 2012-01-24 19:03:30 -08:00			`ADD KEY (phid);`