archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity
Files
bcdb7e9a2c697b5890a789a28006678b06c22d2c
phabricator/support/lint/browser.jshintrc

25 lines
354 B
Plaintext
Raw Normal View History

Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-18 17:04:22 -07:00
{
Be more strict with JSHint. Summary: Add a bunch of extra checks to be performed by `jshint`. For documentation, see http://jshint.com/docs/options/. Test Plan: Ran `jshint --config support/jshint/jshintconfig webroot/rsrc/js/`. There were a bunch of existing violations, but some of these are legitimate and probably require attention. ```lang=json { "bitwise": true, // 0 violations "curly": true, // 0 violations "immed": true, // 1 violation "indent": 2, // 0 violations "latedef": true, // 10 violations "newcap": true, // 1 violation "noarg": true, // 0 violations "quotmark": "single", // 55 violations "undef": true, // 24 violations "unused": true, // 107 violations "expr": true, "loopfunc": true, "sub": true, "globals": { "JX": false, "__DEV__": false }, "browser": true } ``` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9659
2014-06-23 04:07:52 +10:00
"bitwise": true,
"curly": true,
Enable the `freeze` option for JSHint Summary: This option prohibits overwriting prototypes of native objects such as `Array`, `Date` and so on. ```lang=js // jshint freeze:true Array.prototype.count = function (value) { return 4; }; // -> Warning: Extending prototype of native object: 'Array'. ``` Test Plan: Linted existing JavaScript files, found no violations. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11439
2015-01-20 21:25:12 +11:00
"freeze": true,
Be more strict with JSHint. Summary: Add a bunch of extra checks to be performed by `jshint`. For documentation, see http://jshint.com/docs/options/. Test Plan: Ran `jshint --config support/jshint/jshintconfig webroot/rsrc/js/`. There were a bunch of existing violations, but some of these are legitimate and probably require attention. ```lang=json { "bitwise": true, // 0 violations "curly": true, // 0 violations "immed": true, // 1 violation "indent": 2, // 0 violations "latedef": true, // 10 violations "newcap": true, // 1 violation "noarg": true, // 0 violations "quotmark": "single", // 55 violations "undef": true, // 24 violations "unused": true, // 107 violations "expr": true, "loopfunc": true, "sub": true, "globals": { "JX": false, "__DEV__": false }, "browser": true } ``` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9659
2014-06-23 04:07:52 +10:00
"immed": true,
"indent": 2,
"latedef": true,
"newcap": true,
"noarg": true,
"quotmark": "single",
"undef": true,
"unused": true,
"expr": true,
"loopfunc": true,
"sub": true,
"globals": {
"JX": false,
Declare `Raphael` as a global for JSHint Summary: Let JSHint know that `Raphael` is a global that can be used anywhere. This is not technically correct, but it silences a few JSHint warnings. See http://jshint.com/docs/ for more information. Test Plan: `arc lint -- webroot/rsrc/js/application/maniphest/behavior-line-chart.js` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11069
2014-12-30 02:58:22 -08:00
"Raphael": false,
Be more strict with JSHint. Summary: Add a bunch of extra checks to be performed by `jshint`. For documentation, see http://jshint.com/docs/options/. Test Plan: Ran `jshint --config support/jshint/jshintconfig webroot/rsrc/js/`. There were a bunch of existing violations, but some of these are legitimate and probably require attention. ```lang=json { "bitwise": true, // 0 violations "curly": true, // 0 violations "immed": true, // 1 violation "indent": 2, // 0 violations "latedef": true, // 10 violations "newcap": true, // 1 violation "noarg": true, // 0 violations "quotmark": "single", // 55 violations "undef": true, // 24 violations "unused": true, // 107 violations "expr": true, "loopfunc": true, "sub": true, "globals": { "JX": false, "__DEV__": false }, "browser": true } ``` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9659
2014-06-23 04:07:52 +10:00
"__DEV__": false
},
"browser": true
Use `JsShrink` if `jsxmin` is not available Summary: If `jsxmin` is not available, use a pure PHP implementation instead (JsShrink). Test Plan: - Ran `arc lint --lintall` on all JS and fixed every relevant warning. - Forced minification on and browsed around the site using JS behaviors. Didn't hit anything problematic. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5670
2013-05-18 17:04:22 -07:00
}
Reference in New Issue Copy Permalink