phabricator/resources/sql/patches/134.emptysearch.sql

ALTER TABLE `{$NAMESPACE}_search`.`search_document`
  ADD INDEX `documentCreated` (`documentCreated`);
SQL Patch Management: SQL Changes Summary: Splits out the SQL changes. These are most of the changes, but primarily mechanical: - Moved "initialize.sql" to "0000.legacy.sql" and partially reverted to an older version, such that patches 0000 + 000 + 001 + ... + 137 put us in the right state when applied sequentially. - Removed "create database" commands from all SQL. These are handled by separate DB patches now, so we have the data to do operations like "storage databases" (list databases) and "storage destroy" (drop databases). - Removed "phabricator_" namespace from all SQL, and replaced with "{$NAMESPACE}_" token so we can namespace databases. - Shortened some column lengths so patches apply correctly if originally created as InnoDB; also a few similar tweaks elsewhere. Test Plan: See D2323 for discussion and test plan. Reviewers: edward, vrana, btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T140, T345 Differential Revision: https://secure.phabricator.com/D2329 2012-04-30 07:53:53 -07:00			ALTER TABLE `{$NAMESPACE}_search`.`search_document`
Improve performance of empty search Summary: Searching for empty query kills us because whole `search_document` table is read in this case. This diff adds an index just for this query. Other solution would be to disable searching for empty string. But it can be actually useful (listing newest documents of any type). Test Plan: lang=sql EXPLAIN SELECT document.phid, document.documentType, document.documentTitle, document.documentCreated FROM `search_document` document GROUP BY document.phid ORDER BY documentCreated DESC LIMIT 0, 21; Reviewers: epriestley Reviewed By: epriestley CC: jungejason, aran, Koolvin Differential Revision: https://secure.phabricator.com/D2277 2012-04-18 14:38:23 -07:00			ADD INDEX `documentCreated` (`documentCreated`);