Make "View" links on Differential inline comment previews work again
Summary: Ref T11114. Recent changes broke the links to jump to inline comments from the previews because they get hooked up with JS. Restore the linking behavior. Test Plan: Clicked "View" on an inline comment preview, jumped to that comment. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11114 Differential Revision: https://secure.phabricator.com/D17131
This commit is contained in:
@@ -28,6 +28,14 @@ final class PHUIDiffInlineCommentPreviewListView
|
||||
public function render() {
|
||||
$viewer = $this->getViewer();
|
||||
|
||||
$config = array(
|
||||
'pht' => array(
|
||||
'view' => pht('View'),
|
||||
),
|
||||
);
|
||||
|
||||
Javelin::initBehavior('diff-preview-link', $config);
|
||||
|
||||
$inlines = $this->getInlineComments();
|
||||
foreach ($inlines as $key => $inline) {
|
||||
$inlines[$key] = DifferentialInlineComment::newFromModernComment(
|
||||
|
||||
Reference in New Issue
Block a user