Converting badge quality property from color to an integer representation for later sorting purposes

Summary: Ref T9007

Test Plan: Create badges, update quality, search by quality without change of functionality.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Maniphest Tasks: T9007

Differential Revision: https://secure.phabricator.com/D15551

src/applications/badges/controller/PhabricatorBadgesViewController.php

@@ -86,11 +86,12 @@ final class PhabricatorBadgesViewController
     $view = id(new PHUIPropertyListView())
       ->setUser($viewer);
 
-    $quality = idx($badge->getQualityNameMap(), $badge->getQuality());
+    $quality_name = PhabricatorBadgesQuality::getQualityName(
+      $badge->getQuality());
 
     $view->addProperty(
       pht('Quality'),
-      $quality);
+      $quality_name);
 
     $view->addProperty(
       pht('Icon'),