archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Save ApplicationSearch queries generated from GET parameters in the request

Browse Source 
Summary:
Fixes T4239. Currently, if you go to `/maniphest/?authors=alincoln`, operations dependent on the query key (like "Save Custom Query..." and "Export to Excel...") don't have a query key to work with. Make sure they have one.

Also remove a stray `phlog()`.

Test Plan: "Save Custom Query...", etc., now work on GET queries.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4239

Differential Revision: https://secure.phabricator.com/D7777
This commit is contained in:
epriestley
2013-12-16 12:30:51 -08:00
parent b555e4bd91
commit 00f192cebb
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/search/controller/PhabricatorApplicationSearchController.php
View File

@@ -147,6 +147,10 @@ final class PhabricatorApplicationSearchController
$named_query = idx($engine->loadEnabledNamedQueries(), $query_key); $named_query = idx($engine->loadEnabledNamedQueries(), $query_key);
} else { } else {
$saved_query = $engine->buildSavedQueryFromRequest($request); $saved_query = $engine->buildSavedQueryFromRequest($request);
// Save the query to generate a query key, so "Save Custom Query..." and
// other features like Maniphest's "Export..." work correctly.
$this->saveQuery($saved_query);
} }
$nav->selectFilter( $nav->selectFilter(

1
src/applications/search/engine/PhabricatorApplicationSearchEngine.php
View File

@@ -274,7 +274,6 @@ abstract class PhabricatorApplicationSearchEngine {
$user_type = PhabricatorPHIDConstants::PHID_TYPE_USER; $user_type = PhabricatorPHIDConstants::PHID_TYPE_USER;
foreach ($list as $item) { foreach ($list as $item) {
$type = phid_get_type($item); $type = phid_get_type($item);
phlog($type);
if ($type == $user_type) { if ($type == $user_type) {
$phids[] = $item; $phids[] = $item;
} else if (isset($allow_types[$type])) { } else if (isset($allow_types[$type])) {