Rename ManiphestTransactionPro -> ManiphestTransaction

Summary: Ref T2217. Pro is the new standard.

Test Plan: Lots of `grep`, made a pile of Maniphest views/edits.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2217

Differential Revision: https://secure.phabricator.com/D7093

src/applications/search/controller/PhabricatorSearchAttachController.php

@@ -175,11 +175,11 @@ final class PhabricatorSearchAttachController
         $target->getAuthorPHID(),
         $target->getOwnerPHID());
 
-      $close_task = id(new ManiphestTransactionPro())
+      $close_task = id(new ManiphestTransaction())
         ->setTransactionType(ManiphestTransactionType::TYPE_STATUS)
         ->setNewValue(ManiphestTaskStatus::STATUS_CLOSED_DUPLICATE);
 
-      $merge_comment = id(new ManiphestTransactionPro())
+      $merge_comment = id(new ManiphestTransaction())
         ->setTransactionType(PhabricatorTransactions::TYPE_COMMENT)
         ->attachComment(
           id(new ManiphestTransactionComment())
@@ -200,11 +200,11 @@ final class PhabricatorSearchAttachController
 
     $task_names = implode(', ', $task_names);
 
-    $add_ccs = id(new ManiphestTransactionPro())
+    $add_ccs = id(new ManiphestTransaction())
       ->setTransactionType(ManiphestTransactionType::TYPE_CCS)
       ->setNewValue($all_ccs);
 
-    $merged_comment = id(new ManiphestTransactionPro())
+    $merged_comment = id(new ManiphestTransaction())
       ->setTransactionType(PhabricatorTransactions::TYPE_COMMENT)
       ->attachComment(
         id(new ManiphestTransactionComment())