archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Restrict PropertyListView width to just DocumentProView

Browse Source 
Summary: Fixes T10409. Long term need to build a proper "PageEngine" of sorts for layouts not needing special magic. For now this just affects a few applications.

Test Plan: View Diffusion, Phriction, Phame, Legalpad, Diviner.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T10409

Differential Revision: https://secure.phabricator.com/D15328
This commit is contained in:
Chad Little
2016-02-22 11:48:44 -08:00
parent 24104be67d
commit 023cfbb23a
6 changed files with 19 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
resources/celerity/map.php
View File

@@ -81,7 +81,7 @@ return array(
'rsrc/css/application/owners/owners-path-editor.css' => '2f00933b', 'rsrc/css/application/owners/owners-path-editor.css' => '2f00933b',
'rsrc/css/application/paste/paste.css' => 'a5157c48', 'rsrc/css/application/paste/paste.css' => 'a5157c48',
'rsrc/css/application/people/people-profile.css' => '2473d929', 'rsrc/css/application/people/people-profile.css' => '2473d929',
'rsrc/css/application/phame/phame.css' => '4ca6fd6c', 'rsrc/css/application/phame/phame.css' => '737792d6',
'rsrc/css/application/pholio/pholio-edit.css' => '3ad9d1ee', 'rsrc/css/application/pholio/pholio-edit.css' => '3ad9d1ee',
'rsrc/css/application/pholio/pholio-inline-comments.css' => '8e545e49', 'rsrc/css/application/pholio/pholio-inline-comments.css' => '8e545e49',
'rsrc/css/application/pholio/pholio.css' => 'ca89d380', 'rsrc/css/application/pholio/pholio.css' => 'ca89d380',
@@ -127,7 +127,7 @@ return array(
'rsrc/css/phui/phui-button.css' => 'edf464e9', 'rsrc/css/phui/phui-button.css' => 'edf464e9',
'rsrc/css/phui/phui-chart.css' => '6bf6f78e', 'rsrc/css/phui/phui-chart.css' => '6bf6f78e',
'rsrc/css/phui/phui-crumbs-view.css' => '79d536e5', 'rsrc/css/phui/phui-crumbs-view.css' => '79d536e5',
'rsrc/css/phui/phui-document-pro.css' => 'a8872307', 'rsrc/css/phui/phui-document-pro.css' => '92d5b648',
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf', 'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
'rsrc/css/phui/phui-document.css' => '9c71d2bf', 'rsrc/css/phui/phui-document.css' => '9c71d2bf',
'rsrc/css/phui/phui-feed-story.css' => '04aec08f', 'rsrc/css/phui/phui-feed-story.css' => '04aec08f',
@@ -790,7 +790,7 @@ return array(
'phabricator-uiexample-reactor-sendclass' => '1def2711', 'phabricator-uiexample-reactor-sendclass' => '1def2711',
'phabricator-uiexample-reactor-sendproperties' => 'b1f0ccee', 'phabricator-uiexample-reactor-sendproperties' => 'b1f0ccee',
'phabricator-zindex-css' => '5b6fcf3f', 'phabricator-zindex-css' => '5b6fcf3f',
'phame-css' => '4ca6fd6c', 'phame-css' => '737792d6',
'pholio-css' => 'ca89d380', 'pholio-css' => 'ca89d380',
'pholio-edit-css' => '3ad9d1ee', 'pholio-edit-css' => '3ad9d1ee',
'pholio-inline-comments-css' => '8e545e49', 'pholio-inline-comments-css' => '8e545e49',
@@ -812,7 +812,7 @@ return array(
'phui-crumbs-view-css' => '79d536e5', 'phui-crumbs-view-css' => '79d536e5',
'phui-document-summary-view-css' => '9ca48bdf', 'phui-document-summary-view-css' => '9ca48bdf',
'phui-document-view-css' => '9c71d2bf', 'phui-document-view-css' => '9c71d2bf',
'phui-document-view-pro-css' => 'a8872307', 'phui-document-view-pro-css' => '92d5b648',
'phui-feed-story-css' => '04aec08f', 'phui-feed-story-css' => '04aec08f',
'phui-font-icon-base-css' => 'ecbbb4c2', 'phui-font-icon-base-css' => 'ecbbb4c2',
'phui-fontkit-css' => '9cda225e', 'phui-fontkit-css' => '9cda225e',

2
src/applications/diviner/controller/DivinerAtomController.php
View File

@@ -238,6 +238,8 @@ final class DivinerAtomController extends DivinerController {
$document->setToc($side); $document->setToc($side);
} }
$prop_list = phutil_tag_div('phui-document-view-pro-box', $prop_list);
return $this->buildApplicationPage( return $this->buildApplicationPage(
array( array(
$crumbs, $crumbs,

1
src/applications/phame/controller/post/PhamePostViewController.php
View File

@@ -136,6 +136,7 @@ final class PhamePostViewController
$document->setFoot($next_view); $document->setFoot($next_view);
$crumbs = $this->buildApplicationCrumbs(); $crumbs = $this->buildApplicationCrumbs();
$properties = phutil_tag_div('phui-document-view-pro-box', $properties);
$page = $this->newPage() $page = $this->newPage()
->setTitle($post->getTitle()) ->setTitle($post->getTitle())

1
src/applications/phriction/controller/PhrictionDocumentController.php
View File

@@ -218,6 +218,7 @@ final class PhrictionDocumentController
$prop_list = new PHUIPropertyGroupView(); $prop_list = new PHUIPropertyGroupView();
$prop_list->addPropertyList($properties); $prop_list->addPropertyList($properties);
} }
$prop_list = phutil_tag_div('phui-document-view-pro-box', $prop_list);
$page_content = id(new PHUIDocumentViewPro()) $page_content = id(new PHUIDocumentViewPro())
->setHeader($header) ->setHeader($header)

3
webroot/rsrc/css/application/phame/phame.css
View File

@@ -30,9 +30,8 @@
position: absolute; position: absolute;
} }
.phame-blog-description + .phui-property-list-section { .phame-blog-description + .phui-document-view-pro-box {
border-top: 1px solid rgba({$alphablue}, 0.20); border-top: 1px solid rgba({$alphablue}, 0.20);
padding-top: 16px;
} }
.phame-home-view .phui-document-view.phui-document-view-pro { .phame-home-view .phui-document-view.phui-document-view-pro {

13
webroot/rsrc/css/phui/phui-document-pro.css
View File

@@ -20,15 +20,22 @@
margin: 0 auto; margin: 0 auto;
} }
.phui-property-list-section { .device .phui-document-view-pro-box {
max-width: 800px; margin: 0 8px;
}
.phui-document-view-pro-box .phui-property-list-section {
margin: 16px auto; margin: 16px auto;
} }
.device .phui-property-list-section { .device .phui-document-view-pro-box .phui-property-list-section {
margin: 0 8px 16px; margin: 0 8px 16px;
} }
.device .phui-document-view-pro-box .phui-property-list-container {
padding: 24px 0 0 0;
}
.device-phone .phui-document-view.phui-document-view-pro { .device-phone .phui-document-view.phui-document-view-pro {
padding: 0 8px; padding: 0 8px;
margin: 0 auto; margin: 0 auto;