archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix an issue with Duo not live-updating properly on login gates

Browse Source 
Summary:
See <https://discourse.phabricator-community.org/t/duo-broken-in-2019-week-12/2580/>.

The "live update Duo status" endpoint currently requires full sessions, and doesn't work from the session upgrade gate on login.

Don't require a full session to check the status of an MFA challenge.

Test Plan: Went through Duo gate in a new session, got a live update.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20347
This commit is contained in:
epriestley
2019-03-29 09:50:50 -07:00
parent cec779cdab
commit 02f94cd7d2
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/applications/auth/controller/mfa/PhabricatorAuthChallengeStatusController.php
View File

@@ -3,6 +3,12 @@
final class PhabricatorAuthChallengeStatusController final class PhabricatorAuthChallengeStatusController
extends PhabricatorAuthController { extends PhabricatorAuthController {
public function shouldAllowPartialSessions() {
// We expect that users may request the status of an MFA challenge when
// they hit the session upgrade gate on login.
return true;
}
public function handleRequest(AphrontRequest $request) { public function handleRequest(AphrontRequest $request) {
$viewer = $this->getViewer(); $viewer = $this->getViewer();
$id = $request->getURIData('id'); $id = $request->getURIData('id');