Improve implementation of ManiphestTaskQuery
Summary: Currently, we have a single `projectPHIDs` field, and a separate flag which makes it act like AND or OR. This is silly. Make two separate methods for setting `AND` vs `OR` projects. This also simplifies the implmentation. This doesn't change the UI or any behavior (yet), it just makes the API more usable. Test Plan: Loaded homepage, "All Projects" task view, verified queries made sense and returned correct results. Grepped for changed method name. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T1610 Differential Revision: https://secure.phabricator.com/D3630
This commit is contained in:
@@ -247,8 +247,7 @@ final class PhabricatorDirectoryMainController
|
||||
$task_query = new ManiphestTaskQuery();
|
||||
$task_query->withStatus(ManiphestTaskQuery::STATUS_OPEN);
|
||||
$task_query->withPriority(ManiphestTaskPriority::PRIORITY_TRIAGE);
|
||||
$task_query->withProjects(mpull($projects, 'getPHID'));
|
||||
$task_query->withAnyProject(true);
|
||||
$task_query->withAnyProjects(mpull($projects, 'getPHID'));
|
||||
$task_query->setLimit(10);
|
||||
$tasks = $task_query->execute();
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user