archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Mark redirects to php.net from symbols as external

Browse Source 
Summary: Fixes T5942. These are external but currently unmarked.

Test Plan: Visited link, got redirected.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5942

Differential Revision: https://secure.phabricator.com/D10332
This commit is contained in:
epriestley
2014-08-21 14:45:51 -07:00
parent 79c837d505
commit 05eb77c0a7
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/diffusion/controller/DiffusionSymbolController.php
View File

@@ -57,6 +57,7 @@ final class DiffusionSymbolController extends DiffusionController {
$functions = get_defined_functions(); $functions = get_defined_functions();
if (in_array($this->name, $functions['internal'])) { if (in_array($this->name, $functions['internal'])) {
return id(new AphrontRedirectResponse()) return id(new AphrontRedirectResponse())
->setIsExternal(true)
->setURI('http://www.php.net/function.'.$this->name); ->setURI('http://www.php.net/function.'.$this->name);
} }
} }
@@ -65,6 +66,7 @@ final class DiffusionSymbolController extends DiffusionController {
interface_exists($this->name, false)) { interface_exists($this->name, false)) {
if (id(new ReflectionClass($this->name))->isInternal()) { if (id(new ReflectionClass($this->name))->isInternal()) {
return id(new AphrontRedirectResponse()) return id(new AphrontRedirectResponse())
->setIsExternal(true)
->setURI('http://www.php.net/class.'.$this->name); ->setURI('http://www.php.net/class.'.$this->name);
} }
} }