archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Change setErrorView to setInfoView in PHUIObjectBoxView

Browse Source 
Summary: Renames the method in PHUIObjectBoxView to match the new PHUIInfoView class.

Test Plan: grepped codebase. Went to Calendar and tried a new status.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12005
This commit is contained in:
Chad Little
2015-03-06 17:03:18 -08:00
parent 8da5b6255d
commit 076cc6ed7e
17 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/almanac/controller/AlmanacController.php
View File

@@ -195,7 +195,7 @@ abstract class AlmanacController
array($message, ' ', $doc_link),
));
$box->setErrorView($error_view);
$box->setInfoView($error_view);
}
}

2
src/applications/auth/controller/config/PhabricatorAuthListController.php
View File

@@ -161,7 +161,7 @@ final class PhabricatorAuthListController
$list->setFlush(true);
$list = id(new PHUIObjectBoxView())
->setHeader($header)
->setErrorView($warning)
->setInfoView($warning)
->appendChild($list);
return $this->buildApplicationPage(

2
src/applications/calendar/controller/PhabricatorCalendarViewController.php
View File

@@ -42,7 +42,7 @@ final class PhabricatorCalendarViewController
$month_view->setUser($user);
$month_view->setHolidays($holidays);
if ($this->getNoticeView()) {
$month_view->setErrorView($this->getNoticeView());
$month_view->setInfoView($this->getNoticeView());
}
$phids = mpull($statuses, 'getUserPHID');

2
src/applications/config/controller/PhabricatorConfigEditController.php
View File

@@ -202,7 +202,7 @@ final class PhabricatorConfigEditController
->setForm($form);
if ($error_view) {
$form_box->setErrorView($error_view);
$form_box->setInfoView($error_view);
}
$crumbs = $this->buildApplicationCrumbs();

2
src/applications/dashboard/controller/PhabricatorDashboardManageController.php
View File

@@ -55,7 +55,7 @@ final class PhabricatorDashboardManageController
'You do not have permission to edit this dashboard. If you want to '.
'make changes, make a copy first.');
$box->setErrorView(
$box->setInfoView(
id(new PHUIInfoView())
->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
->setErrors(array($no_edit)));

2
src/applications/differential/controller/DifferentialDiffViewController.php
View File

@@ -129,7 +129,7 @@ final class DifferentialDiffViewController extends DifferentialController {
$prop_box = id(new PHUIObjectBoxView())
->setHeader($property_head)
->addPropertyList($property_view)
->setErrorView($error_view);
->setInfoView($error_view);
return $this->buildApplicationPage(
array(

4
src/applications/differential/controller/DifferentialRevisionViewController.php
View File

@@ -261,7 +261,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
$revision_warnings = id(new PHUIInfoView())
->setSeverity(PHUIInfoView::SEVERITY_WARNING)
->setErrors($revision_warnings);
$revision_detail_box->setErrorView($revision_warnings);
$revision_detail_box->setInfoView($revision_warnings);
}
$comment_view = $this->buildTransactions(
@@ -389,7 +389,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
$review_warnings_panel = id(new PHUIInfoView())
->setSeverity(PHUIInfoView::SEVERITY_WARNING)
->setErrors($review_warnings);
$comment_form->setErrorView($review_warnings_panel);
$comment_form->setInfoView($review_warnings_panel);
}
$comment_form->setActions($this->getRevisionCommentActions($revision));

4
src/applications/differential/view/DifferentialAddCommentView.php
View File

@@ -10,7 +10,7 @@ final class DifferentialAddCommentView extends AphrontView {
private $ccs = array();
private $errorView;
public function setErrorView(PHUIInfoView $error_view) {
public function setInfoView(PHUIInfoView $error_view) {
$this->errorView = $error_view;
return $this;
}
@@ -188,7 +188,7 @@ final class DifferentialAddCommentView extends AphrontView {
->appendChild($form);
if ($this->errorView) {
$comment_box->setErrorView($this->errorView);
$comment_box->setInfoView($this->errorView);
}
return array($comment_box, $preview);

4
src/applications/diffusion/controller/DiffusionCommitController.php
View File

@@ -257,7 +257,7 @@ final class DiffusionCommitController extends DiffusionController {
->appendChild(
pht('This commit is very large. Load each file individually.'));
$change_panel->setErrorView($warning_view);
$change_panel->setInfoView($warning_view);
$header->addActionLink($button);
}
@@ -920,7 +920,7 @@ final class DiffusionCommitController extends DiffusionController {
$panel->setHeaderText(pht('Merged Changes'));
$panel->appendChild($history_table);
if ($caption) {
$panel->setErrorView($caption);
$panel->setInfoView($caption);
}
return $panel;

2
src/applications/diffusion/controller/DiffusionExternalController.php
View File

@@ -131,7 +131,7 @@ final class DiffusionExternalController extends DiffusionController {
$content = new PHUIObjectBoxView();
$content->setHeaderText(pht('Multiple Matching Commits'));
$content->setErrorView($caption);
$content->setInfoView($caption);
$content->appendChild($table);
}

2
src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php
View File

@@ -301,7 +301,7 @@ final class LegalpadDocumentSignatureSearchEngine
'NOTE: You can only see your own signatures and signatures on '.
'documents you have permission to edit.'),
));
$box->setErrorView($policy_notice);
$box->setInfoView($policy_notice);
}
return $box;

2
src/applications/maniphest/controller/ManiphestReportController.php
View File

@@ -270,7 +270,7 @@ final class ManiphestReportController extends ManiphestController {
$panel = new PHUIObjectBoxView();
$panel->setHeaderText($header);
if ($caption) {
$panel->setErrorView($caption);
$panel->setInfoView($caption);
}
$panel->appendChild($table);

2
src/applications/maniphest/controller/ManiphestTaskDetailController.php
View File

@@ -351,7 +351,7 @@ final class ManiphestTaskDetailController extends ManiphestController {
->addPropertyList($properties);
if ($info_view) {
$object_box->setErrorView($info_view);
$object_box->setInfoView($info_view);
}
if ($description) {

2
src/applications/people/controller/PhabricatorPeopleInviteSendController.php
View File

@@ -158,7 +158,7 @@ final class PhabricatorPeopleInviteSendController
}
$confirm_box = id(new PHUIObjectBoxView())
->setErrorView(
->setInfoView(
id(new PHUIInfoView())
->setErrors($confirm_errors)
->setSeverity($severity))

2
src/applications/phortune/controller/PhortuneCartViewController.php
View File

@@ -123,7 +123,7 @@ final class PhortuneCartViewController
if ($errors) {
$cart_box->setFormErrors($errors);
} else if ($error_view) {
$cart_box->setErrorView($error_view);
$cart_box->setInfoView($error_view);
}
$charges = id(new PhortuneChargeQuery())

8
src/view/phui/PHUIObjectBoxView.php
View File

@@ -6,7 +6,7 @@ final class PHUIObjectBoxView extends AphrontView {
private $headerColor;
private $formErrors = null;
private $formSaved = false;
private $errorView;
private $infoView;
private $form;
private $validationException;
private $header;
@@ -113,8 +113,8 @@ final class PHUIObjectBoxView extends AphrontView {
return $this;
}
public function setErrorView(PHUIInfoView $view) {
$this->errorView = $view;
public function setInfoView(PHUIInfoView $view) {
$this->infoView = $view;
return $this;
}
@@ -269,7 +269,7 @@ final class PHUIObjectBoxView extends AphrontView {
->appendChild(
array(
$header,
$this->errorView,
$this->infoView,
$this->formErrors,
$this->formSaved,
$exception_errors,

4
src/view/phui/calendar/PHUICalendarMonthView.php
View File

@@ -29,7 +29,7 @@ final class PHUICalendarMonthView extends AphrontView {
return $this;
}
public function setErrorView(PHUIInfoView $error) {
public function setInfoView(PHUIInfoView $error) {
$this->error = $error;
return $this;
}
@@ -192,7 +192,7 @@ final class PHUICalendarMonthView extends AphrontView {
->setHeader($this->renderCalendarHeader($first))
->appendChild($table);
if ($this->error) {
$box->setErrorView($this->error);
$box->setInfoView($this->error);
}